comments extension filters on Parent Class

This allows both pages and DataObjects to have comments without the ParentID clashing and showing comments on a page where the ParentID is the Same as a DataObjects or even two DataObjects having the sameID
This commit is contained in:
Heath Dunlop 2019-05-16 13:46:28 +12:00 committed by GitHub
parent 780ea22b93
commit 82845626bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -254,7 +254,10 @@ class CommentsExtension extends DataExtension
{ {
$order = $this->owner->getCommentsOption('order_comments_by'); $order = $this->owner->getCommentsOption('order_comments_by');
$comments = Comment::get() $comments = Comment::get()
->filter('ParentID', $this->owner->ID) ->filter([
'ParentID' => $this->owner->ID,
'ParentClass' => $this->owner->ClassName,
])
->sort($order); ->sort($order);
$this->owner->extend('updateAllComments', $comments); $this->owner->extend('updateAllComments', $comments);
return $comments; return $comments;