Commit Graph

286 Commits

Author SHA1 Message Date
Guy Sartorelli
9b64c7de24
Merge branch '4' into 5 2022-10-13 11:18:14 +13:00
Steve Boyd
d162fab123
[CVE-2022-37421] Sanitise ExtraMeta field for XSS 2022-10-03 12:55:04 +13:00
Guy Sartorelli
1f360c9c26
ENH Use the new CMSEditLinkExtension on SiteTree (#2778) 2022-09-30 15:10:49 +13:00
Florian Thoma
1711c0c88e
API Move updateRelativeLink hook after concatination (#2770)
* move updateRelativeLink hook after concatination to make it actually updatable

* keep existing parameters the same

* revert to link parameter be first

* update updateRelativeLink method signature in SiteTreeExtension

* don't pass old parameters by reference
2022-08-31 12:33:05 +12:00
Mike Cochrane
b46876b8a8
FIX Don't offer to restore to root if can_be_root is false 2022-08-25 14:18:50 +12:00
Guy Sartorelli
bb158e4f2e
Merge pull request #2730 from creative-commoners/pulls/4/php81
ENH PHP 8.1 compatibility
2022-04-22 16:18:11 +12:00
Guy Sartorelli
5840285d43
Merge pull request #2488 from andrewandante/FEAT/ground_control_to_pager_tom
FEATURE add config var for namespace mapping page->control
2022-04-14 16:02:20 +12:00
Steve Boyd
1b0b2154b4 ENH PHP 8.1 compatibility 2022-04-13 17:07:59 +12:00
Guy Sartorelli
13c1ae487f
Merge pull request #2731 from creative-commoners/pulls/4/p81fix
ENH Various fixes for PHP 8.1 compatibility
2022-04-13 16:10:56 +12:00
Andrew Aitken-Fincham
863ed24920 add config var for namespace mapping page->control, add test to confirm 2022-04-13 12:05:13 +12:00
Will Rossiter
ee69d75904
NEW add ability to redirect to a file on the website 2022-04-12 12:42:58 +12:00
Steve Boyd
6bea5778d7 ENH Various fixes for PHP 8.1 compatibility 2022-04-08 12:38:38 +12:00
Steve Boyd
3b62336180
NEW Include version number in meta generator tag (#2721) 2022-03-09 14:48:02 +13:00
Guy Sartorelli
b4e3a08b8a ENH Prefer dependency injection for GridFieldComponents
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0
Explicitly invoking the injector here instead of using `create()` allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
2022-02-12 18:48:17 +13:00
Steve Boyd
6ab92e8f74 Merge branch '4.10' into 4 2022-02-01 13:58:32 +13:00
Steve Boyd
101b17f16e Merge branch '4.9' into 4.10 2022-02-01 13:58:00 +13:00
Steve Boyd
ab22108c85 Merge branch '4.10' into 4 2022-01-27 09:43:54 +13:00
Florian Thoma
b539924550 FIX SiteTree visibility field name 2022-01-25 11:49:11 +11:00
Sergey Shevchenko
0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Nicolaas / Sunn Side Up
1338538cb9
ENH: better coding standards (#2710) 2022-01-17 12:29:25 +13:00
Steve Boyd
96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd
c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Florian Thoma
480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Adrian Humphreys
ecd9759f83
FIX Remove unused code (#2693) 2021-10-19 12:30:00 +13:00
kevin-hine-innis
2bf691f548
FIX ensure updateAnchorsOnPage extension is called (#2686)
Currently, if there are no anchors found in the page content, the updateAnchorsOnPage extension is not called.
This change will call the updateAnchorsOnPage extension regardless of the page content.
2021-09-28 12:36:37 -07:00
GuySartorelli
734eb3921f
FIX: Treat absolute links in a consistent manner in get_by_link.
Fixes #2580 

The call to `Director::makeRelative` transforms absolute links into relative links. Previously, this meant that you could pass in "https://example.co.nz/about-us" or "about-us" and get the same result, but passing in "https://example.co.nz/" and "/"  would give _different_ results.
This commit performs the transformation to a relative link _before_ checking if the path should be for the home page, which leads to more consistent results.
2021-09-21 17:09:48 +12:00
Nicolaas
10e2c1f271
PATCH: docblock for return value fixed for get_by_link 2021-07-17 11:39:18 +12:00
Nic Horstmeier
85c3b1096b
UPDATE generate canonical via MetaComponents
This replaces using the `MetaTags` method as replacing or removing a canonical requires string manipulation vs unsetting an array key, and is preferred.
2021-04-05 19:52:35 -05:00
Maxime Rainville
fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
brynwhyman
73460f9ee0 FIX remove old syntax from meta tag label 2020-10-13 09:38:03 +13:00
Guy Marriott
a8e8ed71c5
Merge pull request #2588 from creative-commoners/add-docs
Add docs to $enforce_strict_hierarchy
2020-10-04 17:20:42 -07:00
bergice
3bf25681be Add docs to $enforce_strict_hierarchy 2020-09-24 19:27:52 +12:00
Maxime Rainville
edbe5ad069 BUG Remove old boostrap 3 CSS class 2020-09-16 11:06:36 +12:00
Steve Boyd
72e406aa63 Merge branch '4.6' into 4 2020-09-08 14:28:09 +12:00
Steve Boyd
9739308601 Merge branch '4.5' into 4.6 2020-09-08 14:27:46 +12:00
Mojmir Fendek
39b8d14634 BUG: Unpublish permission decoupled from publish permission. 2020-08-31 12:48:43 +12:00
Steve Boyd
c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville
31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Lukas Erni
926571a2bf https://github.com/silverstripe/silverstripe-cms/issues/2557 - remove FQN if lang != EN on SiteType dropdown in page-settings 2020-06-17 16:28:23 +02:00
Maxime Rainville
9974c6e206 Merge branch '4.5' into 4 2020-05-26 14:27:33 +12:00
Garion Herman
891f068202 FIX Correct placement of 'Page location' field title 2020-05-01 15:45:08 +12:00
Nicolaas
22694c7474
PATCH: fixing properties in comments 2020-05-01 11:01:51 +12:00
Michal Kleiner
d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Will Rossiter
6ee17a83e3
NEW Add extension hook updateRedirectionLink() 2020-01-24 22:13:03 +13:00
Amol Wankhede
de96188c8a FIX: If no parent in RelativeLink() return null 2019-12-04 17:08:49 +13:00
Lee Bradley
c8ccd6a8c4 Amends made requested during Pull Request
Requested by @andrewandante & @ScopeyNZ
2019-10-30 09:02:18 +00:00
Lee Bradley
31f99445bd Negotiator amends: Make it possible to disable Preview links in the CMS
Existing functionality is limited to `RedirectorPage`

Another option would be to use the HiddenClass methodology
2019-10-29 17:43:17 +00:00
Serge Latyntcev
c1159c849f Merge branch '4.4' into 4 2019-10-18 13:20:01 +13:00
Serge Latyntcev
06c481bb8d Merge branch '4.3' into 4.4 2019-09-24 14:55:57 +12:00
Serge Latyntsev
c7e44f85aa
Merge pull request #7 from silverstripe-security/pulls/4.3/joseph-installin
[CVE-2019-12204]: install.php warning does not account for public dir
2019-09-24 11:25:49 +12:00
Serge Latyntcev
ac123ee700 Merge branch '4.4' into 4 2019-09-23 16:34:24 +12:00
Serge Latyntcev
4fdcb8180a Merge branch '4.3' into 4.4 2019-09-23 16:22:29 +12:00
Serge Latyntcev
80bcc70d38 Merge branch '4.2' into 4.3 2019-09-23 16:21:50 +12:00
Robbie Averill
6d7cc4f5c0
Merge pull request #2431 from muskie9/pull/pageTypeDropdown#2430
BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
2019-09-16 18:04:23 -07:00
bergice
644376272c Add warnings when trying to remove the homepage
Warnings are triggered when:
* Changing the URL Segment
* Unpublishing
* Unpublishing & Archiving
* Moving the homepage to another parent in the tree view

Also add `SiteTree->isHomePage()`
2019-08-29 17:38:56 +12:00
Aaron Carlino
f98a59deb5 [CVE-2019-12204]: install.php warning does not account for public dir 2019-08-20 21:45:29 +12:00
James Cocker
1316245b37 Updated “URL Segment” & “Main Content” to sentence case 2019-08-14 17:38:36 +01:00
hirenpatel
9bcb395387 Changing to protected to match the rest of the changes 2019-08-02 15:08:05 +01:00
Robbie Averill
a083fc5d5b Merge branch '4.4' into 4 2019-07-19 11:50:38 +02:00
Dylan Wagstaff
68f6eaa663 FIX display recognisable names for dependent content with no title
Content blocks and other DataObjects that contain HTMLText fields are
also used in the 'Dependent pages' report for each page in the CMS,
however these objects may have neither a Title field, nor a name to
describe them. Instead of showing an empty field in the Title column for
this table, we can instead show "Untitled " with the localised singular
name appended.
2019-07-17 15:30:07 +12:00
Aaron Carlino
8a44071ec6 Merge branch '4.4' into 4 2019-06-10 16:26:55 +12:00
Robbie Averill
325d227fe0 FIX Virtual page notice now uses Bootstrap 4 alerts 2019-05-31 14:50:46 +12:00
Maxime Rainville
46b77f3592 MINOR Do not assume SiteTree's table will always be call SiteTree. 2019-05-17 13:40:15 +12:00
Nic Horstmeier
1b3a4aea96 BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
resolves #2430
2019-05-16 19:53:59 -05:00
Loz Calver
7592db918f FIX: VirtualPage missing methods from target page (fixes #2408) 2019-04-18 14:01:26 +01:00
ttunua
0b56a563c0 FIX: Fixes #2110 added default Title value for saved pages. (#2366)
* FIX: Fixes #2110 added default Title value for saved pages.

* FIX: Fixes #2110 fixed linting and unit test failure

* BUG Rename default wording for untitled page
2019-04-15 14:33:15 +12:00
Guy Marriott
d2236f0954
Update code/Model/SiteTree.php
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
2019-04-08 11:45:52 +12:00
Guy Marriott
10ff962ece
Update code/Model/SiteTree.php
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
2019-04-08 11:45:44 +12:00
Guy Marriott
4685523b9b
Update code/Model/SiteTree.php
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
2019-04-08 11:10:07 +12:00
Sacha Judd
a0aaf050d4 FIX Deprecate creatableChildren and add new function to support font-icon classes for allowedChildren 2019-02-25 17:00:47 +13:00
Robbie Averill
c1c9d7706a Merge branch '4.3' into 4 2019-02-06 22:25:40 +03:00
Robbie Averill
23ae682b35 Merge branch '4.2' into 4.3 2019-02-06 22:24:53 +03:00
Robbie Averill
976bbc1014 Merge branch '4.1' into 4.2 2019-02-06 22:24:32 +03:00
Robbie Averill
668670b5a1 Merge branch '4.0' into 4.1 2019-02-06 22:24:14 +03:00
Ingo Schommer
f8a8b38a0a Consistent check of allow_multibyte
It uses an injected instance everywhere else.
See https://github.com/silverstripe/silverstripe-cms/pull/2365#discussion_r247383809
2019-02-05 16:45:28 +03:00
Guy Marriott
97ee18d463
Merge pull request #2382 from creative-commoners/pulls/4.4/remove-add-to-campaign-button
FIX Remove coupling from SiteTree to campaign admin module
2019-02-04 22:20:35 +13:00
Ingo Schommer
12274fb6ec Consistent check of allow_multibyte
It uses an injected instance everywhere else.
See https://github.com/silverstripe/silverstripe-cms/pull/2365#discussion_r247383809
2019-02-04 22:04:48 +13:00
Maxime Rainville
ed0680a264 MINOR Add unit test for MetaComponents 2019-02-01 19:48:47 +03:00
Robbie Averill
f9aeeb1d6c FIX Remove coupling from SiteTree to campaign admin module
Add to Campaign button is now in an extension in the campaign-admin module
2019-02-01 19:36:13 +03:00
Maxime Rainville
53374d617e
Merge pull request #2280 from creative-commoners/pulls/4.2/subsites-namespace
FIX Use correct subsites namespace in SiteTree and test classes
2019-02-01 17:27:35 +13:00
Jonathon Menz
e20be9293f NEW Meta tag components
Meta tags can now be individually accessed and modified by key, prior to being rendered and flattened in to a single string.
2019-02-01 14:49:01 +13:00
Sacha Judd
1f1f44969a NEW Add font-icon support for site tree 2019-01-14 13:16:30 +13:00
Aaron Carlino
6beb682cfa Merge branch '4.3' into 4 2019-01-10 12:06:36 +13:00
Aaron Carlino
b83d818e0a Merge branch '4.2' into 4.3 2018-12-11 17:07:55 +13:00
Aaron Carlino
acc7f46b02 Merge branch '4.1' into 4.2 2018-12-11 11:42:35 +13:00
Aaron Carlino
a4b78c4041 Merge branch '4.0' into 4.1 2018-12-11 11:42:11 +13:00
Robbie Averill
84db517bfe Merge branch 'pr-2105' into 4.0 2018-12-02 18:21:40 +00:00
Robbie Averill
0bb22732c9 FIX Unsaved SiteTree records now return an empty list for DependentPages 2018-11-28 13:44:52 +01:00
Robbie Averill
60aadf8f28 Merge branch '4.3' into 4 2018-11-26 15:09:38 +01:00
Robbie Averill
ce3a1ce913 FIX Use correct subsites namespace in SiteTree and test classes 2018-11-20 13:34:38 +01:00
Robbie Averill
03869b1627 Remove undefined variable, should use the baseTable() from the $parentClass 2018-11-15 13:30:33 +02:00
Maxime Rainville
b138eb06ff Revert BackLinkTracking to return Parent Object of the SiteTreeLink rather than SiteTreeLink itself 2018-11-15 15:57:17 +13:00
Maxime Rainville
0bff8728b1 MINOR Speed up DependentPages by shifting existence check to table join 2018-11-14 18:01:29 +13:00
Robbie Averill
ab739c7fb0 FIX Replace usage of Convert JSON methods with json_encode and json_decode 2018-10-28 21:21:19 +00:00
Maxime Rainville
974ea3b29d MINOR Remove AbsoluteURL column from DependentPage (#2290) 2018-10-11 14:42:16 +13:00
Maxime Rainville
7f0d4c8634 MINOR Enable the lazy loading for DependentPages GridField 2018-10-09 14:16:43 +13:00
Luke Edwards
aa3760ed66
Merge pull request #2247 from open-sausages/pulls/4.2/2227-show-link-tracking
API: Add `show_link_tracking` config to `SiteTreeLinkTracking` extension
2018-09-13 14:23:54 +12:00
bergice
115ed92e0a API: Add show_sitetree_link_tracking config to SiteTreeLinkTracking extension to control visibility of the Link Tracking tab 2018-09-13 11:01:33 +12:00
Daniel Hensby
83e5689b94
Merge branch '4.2' into 4 2018-07-23 15:58:14 +01:00