tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

MINOR Add unit test for MetaComponents

Browse Source
This commit is contained in:
Maxime Rainville 2019-02-01 16:00:11 +13:00 committed by Robbie Averill
parent e20be9293f
commit ed0680a264
2 changed files with 52 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
code/Model/SiteTree.php
View File

@ -1380,7 +1380,6 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
$tags['title'] = [
'tag' => 'title',
'attributes' => [],
'content' => $this->obj('Title')->forTemplate()
];
@ -1442,7 +1441,7 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
{
$tags = [];
$tagsArray = $this->MetaComponents();
if (!$includeTitle) {
if (!$includeTitle || strtolower($includeTitle) == 'false') {
unset($tagsArray['title']);
}

51
tests/php/Model/SiteTreeTest.php
View File

@ -1353,6 +1353,57 @@ class SiteTreeTest extends SapphireTest
// Test without title
$meta = $page->MetaTags(false);
$this->assertNotContains('<title>', $meta);
$meta = $page->MetaTags('false');
$this->assertNotContains('<title>', $meta);
}
public function testMetaComponents()
{
$this->logInWithPermission('ADMIN');
/** @var SiteTree $page */
$page = $this->objFromFixture('Page', 'metapage');
$charset = Config::inst()->get(ContentNegotiator::class, 'encoding');
$expected = [
'title' => [
'tag' => 'title',
'content' => "HTML &amp; XML",
],
'generator' => [
'attributes' => [
'name' => 'generator',
'content' => Config::inst()->get(SiteTree::class, 'meta_generator')
],
],
'contentType' => [
'attributes' => [
'http-equiv' => 'Content-Type',
'content' => "text/html; charset=$charset",
],
],
'description' => [
'attributes' => [
'name' => 'description',
'content' => 'The <br /> and <br> tags'
]
],
'pageId' => [
'attributes' => [
'name' => 'x-page-id',
'content' => $page->ID
],
],
'cmsEditLink' => [
'attributes' => [
'name' => 'x-cms-edit-link',
'content' => $page->CMSEditLink()
]
]
];
$this->assertEquals($expected, $page->MetaComponents());
}
/**