Commit Graph

1426 Commits

Author SHA1 Message Date
Ingo Schommer
e30f92a2f8 API CHANGE Returning empty form from getEditForm() method in CMSMain, AssetAdmin, SecurityAdmin to avoid an <% if %> condition in the template. The previous placeholder text is now always stored alongside the form template. This also allows for easier class overloading with different URLs, as the form action is no longer hardcoded in the template placeholder form.
BUGFIX Adjusted AssetAdmin_left.ss, CommentAdmin_left.ss
MINOR Removed CommentAdmin_right.ss, SecurityAdmin_right.ss - inherits a more generic LeftAndMain_right.ss instead
MINOR Merged CommentAdmin_SiteTree.ss template back into CommentAdmin_left.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:00 +00:00
Ingo Schommer
40e3f96ce8 MINOR PHP Notice in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:56 +00:00
Ingo Schommer
9794b8324b MINOR Fixed height of loading screen for IE6
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92703 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:53 +00:00
Ingo Schommer
7561dc69bc MINOR Fixed height of loading screen for IE6
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92702 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:51 +00:00
Ingo Schommer
7400f8e3d1 ENHANCEMENT Using concrete for CMS loading screen javascript
ENHANCEMENT Better styling for non-javascript message in CMS loading screen

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92701 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:49 +00:00
Ingo Schommer
febe9f6e8b MINOR Removed unnecessary CMSMain_right.js javascript, was only used for form changetracking which has changed its API since
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:45 +00:00
Ingo Schommer
d478f175b7 MINOR Layout manager tweaks
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92699 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:43 +00:00
Ingo Schommer
5e4fa55472 MINOR Moved tinymce initialization from LeftAndMain.js to LeftAndMain.EditForm.js and converted to use concrete
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92698 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:40 +00:00
Ingo Schommer
ffb6790fe6 BUGFIX Fixed duplicated 'confirm save' message in changetracker logic for LeftAndMain.EditForm.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:38 +00:00
Ingo Schommer
8b8867ba76 API CHANGE Changed <p id=statusMessage> to <div class=notice-wrap> in LeftAndMain_right.ss and subclasses
ENHANCEMENT Using external jquery.notice library to handle status message updates in the CMS

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:36 +00:00
Ingo Schommer
42a5de8536 MINOR Removed unused _AJAX_LOADING global from LeftAndMain.js javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:30 +00:00
Ingo Schommer
bf6ff4addb MINOR Moved tree context menu javascript from LeftAndMain.js into LeftAndMain_left.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:28 +00:00
Ingo Schommer
fe82f394f1 API CHANGE Removed unused ajaxSubmitForm() javascript in LeftAndMain.js, please use LeftAndMain.EditForm.js instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:26 +00:00
Ingo Schommer
140fae5d7e API CHANGE Removed AssetAdmin_right.ss template, using LeftAndMain_right.ss now
API CHANGE Removed CMSMain_right.ss template, moved one level up to LeftAndMain_right.ss to be inheritable by other LeftAndMain subclasses

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92692 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:24 +00:00
Ingo Schommer
c48c7755bb ENHANCEMENT Moving placeholder HTML for CMS EditForm out of the <form> tag, and picking it up for later usage in the EditForm javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92691 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:22 +00:00
Ingo Schommer
471afa4002 MINOR Changed statusMessage container in LeftAndMain_right.ss to a <div> so we can save ourselves the CSS styling defaults
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92690 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:18 +00:00
Ingo Schommer
4c5e847625 BUGFIX Fixes to CMS EditForm javascript change tracking and event triggering
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92689 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:17 +00:00
Ingo Schommer
f267dac02c BUGFIX Updated jquery.changetracker behaviour in LeftAndMain javascript to properly respond to window.onbeforeunload events
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92688 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:14 +00:00
Ingo Schommer
55ed72d2aa BUGFIX Made CMSMain.js EditForm concrete rule more specifc, to avoid problems with super()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92687 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:12 +00:00
Ingo Schommer
73e9d884aa MINOR Removing commented out StatusTitle logic in LeftAndMain.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92686 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:10 +00:00
Ingo Schommer
5aef49a0a7 API CHANGE Removed ChangeTracker javascript class, superseded by jquery.changetracker
API CHANGE Removed autoSave() javascript logic in CMS, superseded by custom code in LeftAndMain.EditForm.js
ENHANCEMENT Using jquery.changetracker in LeftAndMain.EditForm.js, and overhauled window.unload logic to automatically trigger ajax saving after a user confirmation
MINOR Changed unload confirmation text in CMS logic to adapt to new behaviour

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92685 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:08 +00:00
Ingo Schommer
5f8a164d21 ENHANCEMENT Defaulting to action_save button in ajaxSubmit() javascript logic in CMS form
ENHANCEMENT Making ajax options overrideable in ajaxSubmit() javascript logic in CMS form

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92684 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:05 +00:00
Ingo Schommer
54a7beb5e7 BUGFIX Fixed fieldSelector logic in jquery.changetracker
MINOR Fixed removeData() invocation in jquery.changetracker
MINOR Removed debug code in jquery.changetracker

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92683 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:03 +00:00
Ingo Schommer
6514dc35d4 MINOR Removed debug code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92682 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:00 +00:00
Ingo Schommer
b6dc2dec79 ENHANCEMENT Added initial implementation of jquery-changetracker as a replacement for the existing ChangeTracker behaviour/prototype javascript class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92681 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:13:58 +00:00
Ingo Schommer
bc2cad4670 ENHANCEMENT Floating tinymce toolbar icons in CMS to allow for smaller widths without having tinymce hide the tabset scrollbars
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92680 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:26 +00:00
Ingo Schommer
4726893607 BUGFIX Adjusted WidgetAreaEditor javascript to new event names triggered by CMS forms
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92679 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:24 +00:00
Ingo Schommer
3725a98da3 MINOR Added check for presence of origData in LeftAndMain event handler javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92678 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:22 +00:00
Ingo Schommer
d90d672158 MINOR Syntax
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92677 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:20 +00:00
Ingo Schommer
1bac2dc4aa BUGFIX Fixed ParentType selector javascript in SiteTree->getCMSFields()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92676 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:18 +00:00
Ingo Schommer
21160c6ccb BUGFIX Fixed _setupPinging() javascript logic to comply to jQuery callback arguments
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92675 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:14 +00:00
Ingo Schommer
c2d24f9022 FEATURE Changed CMSMain and LeftAndMain form submissions to return raw HTML instead of using FormResponse logic and evaluated javascript. This allows a more customizeable UI layer that is decoupled from the serverside logic. Any state changes should be propagated through the form itself.
ENHANCEMENT Using new 'X-STATUS' HTTP response header for CMS form responses, as it is more robust for submitting variable length strings than the original 'Status' header. The status is evaluated in LeftAndMain.EditForm.js
API CHANGE Removed CMSMain->tellBrowserAboutPublicationChange(), LeftAndMain->returnItemToUser(), LeftAndMain->getActionUpdateJS(), LeftAndMain->addTreeNodeJS(), LeftAndMain->deleteTreeNodeJS(). Use javascript to respond to state changes
API CHANGE Removed CMSForm and CMSRightForm javascript classes, superseded by LeftAndMain.EditForm.js
ENHANCEMENT Removed custom change detection in LeftAndMain->save(), this should be handled by DataObject->write()
ENHANCEMENT Removed switch in LeftAndMain->save() which doesnt process saving if the record hasn't been altered, to simplify the saving logic
ENHANCEMENT Removed custom add/remove tree node logic in LeftAndMain->save() which was retrieving state from DataObjectLog. This was never actively used, and should be handled by custom clientside logic.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:12 +00:00
Ingo Schommer
a397804db6 MINOR Set loading state on icons for CMS form loading javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92673 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:08 +00:00
Ingo Schommer
41c1c49dfe ENHANCEMENT Better response handling in LeftAndMain.EditForm
BUGFIX Fixed event cancellation in LeftAndMain.EditForm javascript buttons

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92672 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:06 +00:00
Ingo Schommer
b99ee16d88 ENHANCEMENT Removed CMSMain->jsDeclaration(), it was replicating functionality already present in Convert::raw2js()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92671 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:04 +00:00
Ingo Schommer
8b89a265da MINOR Removed defunct param parsing in LeftAndMain->show(), wasn't working since we switched to RequestHandler in 2.2
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92670 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:01 +00:00
Ingo Schommer
0b9f4ab533 MINOR Adjusted to SiteTree->getTreeTitle() api change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92669 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:59 +00:00
Ingo Schommer
fef02e8b1e BUGFIX Changed TreeNodeAPI->setNodeIcon() javascript to not require the old classname to replace. All PHP classnames stored in CSS class strings now have the prefix 'class-' which makes them easy to detect without context
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92668 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:56 +00:00
Ingo Schommer
a9c257bc2f MINOR Re-enabled statusmessage in CMSMain_right.ss template
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92667 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:54 +00:00
Ingo Schommer
e8f5b3fbe4 MINOR documentations
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92666 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:52 +00:00
Ingo Schommer
df313826e0 MINOR Fixed unload logic in MainMenu javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92665 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:50 +00:00
Ingo Schommer
59999e197e MINOR Supporting override attributes in hidden form fields in LeftAndMain.EditForm.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92664 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:48 +00:00
Ingo Schommer
d03eb541ef MINOR Remove text for LeftAndMain.EditForm.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92663 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:46 +00:00
Ingo Schommer
371abfdd1d BUGFIX Monitoring form for locale changes in CMSMain.Translatable.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92662 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:44 +00:00
Ingo Schommer
b9041367bf BUGFIX Ensuring the padding rules for loading indicators in CMS action buttons are properly applied
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92661 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:42 +00:00
Ingo Schommer
87a6e331e9 ENHANCEMENT Disabling validator in CMSMain->getCMSFields() unless its explicitly set through SiteTree->getCMSValidator(). We don't fully support validation in the CMS (yet), and it causes unnecessary bloat in the document body for now.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92660 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:39 +00:00
Ingo Schommer
b96a69d716 MINOR Setting ID fields in CMSMain->getEditForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92659 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:37 +00:00
Ingo Schommer
61a3d03883 MINOR Fixed indentation and documentation in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92658 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:35 +00:00
Ingo Schommer
48bbfeffa4 MINOR Temporary workaround for event handling in namespaces for concrete library
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:33 +00:00
Ingo Schommer
4809523bae MINOR JavaScript code indentation and formatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92656 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:31 +00:00