Commit Graph

784 Commits

Author SHA1 Message Date
Andre Kiste 87ac196378
Merge pull request #2585 from open-sausages/pulls/4/toast-react
BUG Fix Behat test to use new toast notification step
2021-05-21 15:43:24 +12:00
Steve Boyd d7570cb0e6 MNT Use behat-extension function for clicking elements 2021-04-15 13:42:45 +12:00
Steve Boyd acbcf4660c Merge branch '4.6' into 4.7 2021-03-21 10:25:47 +13:00
Steve Boyd 1ccf67b158 MNT Fix archive button behat test 2021-03-18 15:15:16 +13:00
Steve Boyd babc8a462e Merge branch '4.6' into 4.7 2021-01-02 10:40:57 +13:00
Garion Herman af5f7fc445 FIX Re-patch language in behat reports test
The language string supporting the title of this report was updated, then
reverted, then updated again, but the related behat test didn't get re-updated
at the same time.
2020-12-09 14:34:16 +13:00
Steve Boyd 9e2d04ab90 MNT Fix broken pages with no content behat test 2020-11-06 13:02:50 +13:00
Steve Boyd 4e10bcfc51 ENH Disable option to create top-level pages based on permissions 2020-10-22 21:21:15 +13:00
Garion Herman f9f440c35d
Merge pull request #2602 from creative-commoners/pulls/4/fix-pgsql-unit-test-run
MNT Fix unit tests not running on PGSQL build
2020-10-22 15:15:50 +13:00
Garion Herman 8a16d708d4 FIX Use Live stage to fetch results during SearchFormTest
This resolves an issue with the testUnpublishedPagesNotIncluded case
when running against PostgreSQL.
2020-10-22 14:42:27 +13:00
Maxime Rainville fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
Maxime Rainville f4edd35989 Merge branch '4.5' into 4.6 2020-10-22 10:50:44 +13:00
Maxime Rainville aaf4fb4d7a BUG Remove broken RESOURCES_DIR test 2020-10-15 15:12:44 +13:00
Mojmir Fendek 0fcda80f02 BUG: URL segment filter correction for CMS page search. 2020-10-06 08:37:22 +13:00
Maxime Rainville 2332831a2d BUG Fix Behat test to use new toast notification step 2020-09-17 17:48:32 +12:00
Steve Boyd c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville 31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Nicolaas Thiemen bbb69cfb5a PATCH: fixing behat wording 2020-07-08 13:50:47 +12:00
Michal Kleiner d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Ingo Schommer e51bd421a6 FIX InnoDB FULLTEXT compat in tests
> InnoDB FULLTEXT indexes have special transaction handling characteristics due its caching and batch processing behavior. Specifically, updates and insertions on a FULLTEXT index are processed at transaction commit time, which means that a FULLTEXT search can only see committed data. The following example demonstrates this behavior. The FULLTEXT search only returns a result after the inserted lines are committed.

https://dev.mysql.com/doc/refman/5.6/en/innodb-fulltext-index.html#innodb-fulltext-index-transaction
2020-04-09 11:05:19 +12:00
Ingo Schommer dd839ca2d9 FIX Remove searchEngine() test that's using API wrong
Required to allow InnoDB usage, see https://github.com/silverstripe/silverstripe-framework/pull/9454.

This came up in https://github.com/silverstripe/silverstripe-cms/issues/1452, and wasn't fully addressed.
Either we allow boolean mode and all the constraints this brings around special character usage,
or we filter out those special characters, which makes boolean mode pointless.
You can't just pass arbitrary user input in a power-user function like this.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html

Context: This used to work for some examples like "foo>*" under MyISAM,
presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
2020-04-09 09:59:53 +12:00
Serge Latyntcev ac123ee700 Merge branch '4.4' into 4 2019-09-23 16:34:24 +12:00
Serge Latyntcev 4fdcb8180a Merge branch '4.3' into 4.4 2019-09-23 16:22:29 +12:00
Serge Latyntcev 80bcc70d38 Merge branch '4.2' into 4.3 2019-09-23 16:21:50 +12:00
Robbie Averill 6d7cc4f5c0
Merge pull request #2431 from muskie9/pull/pageTypeDropdown#2430
BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
2019-09-16 18:04:23 -07:00
Robbie Averill a083fc5d5b Merge branch '4.4' into 4 2019-07-19 11:50:38 +02:00
Dylan Wagstaff 68f6eaa663 FIX display recognisable names for dependent content with no title
Content blocks and other DataObjects that contain HTMLText fields are
also used in the 'Dependent pages' report for each page in the CMS,
however these objects may have neither a Title field, nor a name to
describe them. Instead of showing an empty field in the Title column for
this table, we can instead show "Untitled " with the localised singular
name appended.
2019-07-17 15:30:07 +12:00
Sam Minnee 469e7ca01b FIX: Make test comparison less brittle in MigrateSiteTreeLinkingTaskTest
Comparing every single field is unnecessary and brittle, only the IDs
need to be compared.

Notably this tripped over a potential bug fix in
https://github.com/silverstripe/silverstripe-framework/pull/8591
but the change should be incorporated regardless.
2019-05-28 12:51:23 +12:00
Nic Horstmeier 1b3a4aea96 BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
resolves #2430
2019-05-16 19:53:59 -05:00
Loz Calver 7592db918f FIX: VirtualPage missing methods from target page (fixes #2408) 2019-04-18 14:01:26 +01:00
Robbie Averill 79e1b06d17
Merge pull request #2373 from sminnee/search-or-choose-page
MINOR: Change “Choose Page” to “Search or choose Page”
2019-04-17 12:30:46 +12:00
ttunua 0b56a563c0 FIX: Fixes #2110 added default Title value for saved pages. (#2366)
* FIX: Fixes #2110 added default Title value for saved pages.

* FIX: Fixes #2110 fixed linting and unit test failure

* BUG Rename default wording for untitled page
2019-04-15 14:33:15 +12:00
Robbie Averill d4571d927d Merge branch '4.3' into 4 2019-04-11 11:46:19 +12:00
Serge Latyntcev de5fc49917 Remove flush from CMSPageHistoryControllerTest
flushing in tests is futile
2019-04-01 10:58:53 +13:00
Robbie Averill abd661bfab SiteTreeTest::testReadArchiveDate() now tests ORM results rather than underlying sql arguments 2019-02-11 14:30:25 +03:00
Robbie Averill c1c9d7706a Merge branch '4.3' into 4 2019-02-06 22:25:40 +03:00
Robbie Averill 23ae682b35 Merge branch '4.2' into 4.3 2019-02-06 22:24:53 +03:00
Robbie Averill 976bbc1014 Merge branch '4.1' into 4.2 2019-02-06 22:24:32 +03:00
Robbie Averill 668670b5a1 Merge branch '4.0' into 4.1 2019-02-06 22:24:14 +03:00
Ingo Schommer 5c3b95ac89 FIX Multibyte URL routing
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
2019-02-05 16:45:28 +03:00
Robbie Averill ff458810ea Automated phpcs linting updates 2019-02-05 16:45:11 +03:00
Guy Marriott 97ee18d463
Merge pull request #2382 from creative-commoners/pulls/4.4/remove-add-to-campaign-button
FIX Remove coupling from SiteTree to campaign admin module
2019-02-04 22:20:35 +13:00
Ingo Schommer c61ba88d82 FIX Multibyte URL routing
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
2019-02-04 22:02:15 +13:00
Robbie Averill 1a7b23a21f FIX URL segment generation tests for resources dir are now accurate 2019-02-02 13:27:24 +03:00
Robbie Averill 3dbca48d29 Remove assertions for addtocampaign action 2019-02-01 20:20:40 +03:00
Maxime Rainville ed0680a264 MINOR Add unit test for MetaComponents 2019-02-01 19:48:47 +03:00
Maxime Rainville 53374d617e
Merge pull request #2280 from creative-commoners/pulls/4.2/subsites-namespace
FIX Use correct subsites namespace in SiteTree and test classes
2019-02-01 17:27:35 +13:00
Sam Minnee dd06178167 MINOR: Change “Choose Page” to “Search or choose Page”
Based on discussions with James Ford, it wasn’t clear that you could
search.

Companion to https://github.com/silverstripe/silverstripe-framework/pull/8766
2019-01-29 12:15:38 +13:00
Maxime Rainville bbffe05541 Fixing linting error. 2019-01-12 00:16:04 +13:00
Maxime Rainville 3a1329f61b MINOR Clean up CMSMain::CanOrganiseSitetree 2019-01-11 23:56:40 +13:00