Commit Graph

858 Commits

Author SHA1 Message Date
Guy Sartorelli
ff1c529898 Merge branch '4.11' into 4 2022-07-11 11:33:02 +12:00
Guy Sartorelli
4d679ab4db FIX Hide uploadfield in redirector page by default 2022-07-08 13:58:47 +12:00
Guy Sartorelli
ead1d2f02b FIX Always include unsaved anchors from the current WYSIWYG field 2022-06-13 11:17:38 +12:00
Guy Sartorelli
3a990c95f5 MNT Correct test SilverStripeNavigatorItems. 2022-05-06 14:38:00 +12:00
Guy Sartorelli
bb158e4f2e
Merge pull request #2730 from creative-commoners/pulls/4/php81
ENH PHP 8.1 compatibility
2022-04-22 16:18:11 +12:00
Steve Boyd
1b0b2154b4 ENH PHP 8.1 compatibility 2022-04-13 17:07:59 +12:00
Andrew Aitken-Fincham
863ed24920 add config var for namespace mapping page->control, add test to confirm 2022-04-13 12:05:13 +12:00
Will Rossiter
ee69d75904
NEW add ability to redirect to a file on the website 2022-04-12 12:42:58 +12:00
Steve Boyd
3b62336180
NEW Include version number in meta generator tag (#2721) 2022-03-09 14:48:02 +13:00
Sergey Shevchenko
0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Steve Boyd
854393346f
MNT Assert string 2021-11-19 09:52:29 +13:00
Maxime Rainville
b888dc1414
Merge pull request #2689 from creative-commoners/pulls/4.9/behat
MNT Update behat tests
2021-11-18 17:17:27 +13:00
Steve Boyd
96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd
1e3970fefd MNT Update behat tests 2021-11-17 14:10:48 +13:00
Steve Boyd
c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Guy Sartorelli
1db69ee91a ENH: Add tests for absolute URLs in get_by_link 2021-11-15 14:30:44 +13:00
Florian Thoma
480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Steve Boyd
360fbcd878 API phpunit9 support 2021-10-28 10:40:52 +13:00
Aaron Carlino
f3a76ccf2d
NEW: getByLink plugin allows arrays of links (#2666)
* NEW: getByLink plugin allows arrays of links

* Allow configurable resolver

* Remove unused exception tag

* Refactor to preserve API backward compat

* Unit test

* Add plugin to readOne

* Fix test

* add new test
2021-09-07 09:34:52 +12:00
Steve Boyd
db9d86eade MNT Use logInAs() for unit tests 2021-08-18 17:18:01 +12:00
Steve Boyd
e98110d336
MNT Update tests to use logInAs() (#2679) 2021-08-18 12:35:36 +12:00
Steve Boyd
12c11e5308 Merge branch '4.8' into 4 2021-07-07 14:01:30 +12:00
Steve Boyd
c2026d06bf MNT Update embed shortcode unit test 2021-06-29 12:53:48 +12:00
Andre Kiste
87ac196378
Merge pull request #2585 from open-sausages/pulls/4/toast-react
BUG Fix Behat test to use new toast notification step
2021-05-21 15:43:24 +12:00
Steve Boyd
d7570cb0e6 MNT Use behat-extension function for clicking elements 2021-04-15 13:42:45 +12:00
Steve Boyd
acbcf4660c Merge branch '4.6' into 4.7 2021-03-21 10:25:47 +13:00
Steve Boyd
1ccf67b158 MNT Fix archive button behat test 2021-03-18 15:15:16 +13:00
Steve Boyd
babc8a462e Merge branch '4.6' into 4.7 2021-01-02 10:40:57 +13:00
Garion Herman
af5f7fc445 FIX Re-patch language in behat reports test
The language string supporting the title of this report was updated, then
reverted, then updated again, but the related behat test didn't get re-updated
at the same time.
2020-12-09 14:34:16 +13:00
Steve Boyd
9e2d04ab90 MNT Fix broken pages with no content behat test 2020-11-06 13:02:50 +13:00
Steve Boyd
4e10bcfc51 ENH Disable option to create top-level pages based on permissions 2020-10-22 21:21:15 +13:00
Garion Herman
f9f440c35d
Merge pull request #2602 from creative-commoners/pulls/4/fix-pgsql-unit-test-run
MNT Fix unit tests not running on PGSQL build
2020-10-22 15:15:50 +13:00
Garion Herman
8a16d708d4 FIX Use Live stage to fetch results during SearchFormTest
This resolves an issue with the testUnpublishedPagesNotIncluded case
when running against PostgreSQL.
2020-10-22 14:42:27 +13:00
Maxime Rainville
fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
Maxime Rainville
f4edd35989 Merge branch '4.5' into 4.6 2020-10-22 10:50:44 +13:00
Maxime Rainville
aaf4fb4d7a BUG Remove broken RESOURCES_DIR test 2020-10-15 15:12:44 +13:00
Mojmir Fendek
0fcda80f02 BUG: URL segment filter correction for CMS page search. 2020-10-06 08:37:22 +13:00
Maxime Rainville
2332831a2d BUG Fix Behat test to use new toast notification step 2020-09-17 17:48:32 +12:00
Steve Boyd
c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville
31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Nicolaas Thiemen
bbb69cfb5a PATCH: fixing behat wording 2020-07-08 13:50:47 +12:00
Michal Kleiner
d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Ingo Schommer
e51bd421a6 FIX InnoDB FULLTEXT compat in tests
> InnoDB FULLTEXT indexes have special transaction handling characteristics due its caching and batch processing behavior. Specifically, updates and insertions on a FULLTEXT index are processed at transaction commit time, which means that a FULLTEXT search can only see committed data. The following example demonstrates this behavior. The FULLTEXT search only returns a result after the inserted lines are committed.

https://dev.mysql.com/doc/refman/5.6/en/innodb-fulltext-index.html#innodb-fulltext-index-transaction
2020-04-09 11:05:19 +12:00
Ingo Schommer
dd839ca2d9 FIX Remove searchEngine() test that's using API wrong
Required to allow InnoDB usage, see https://github.com/silverstripe/silverstripe-framework/pull/9454.

This came up in https://github.com/silverstripe/silverstripe-cms/issues/1452, and wasn't fully addressed.
Either we allow boolean mode and all the constraints this brings around special character usage,
or we filter out those special characters, which makes boolean mode pointless.
You can't just pass arbitrary user input in a power-user function like this.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html

Context: This used to work for some examples like "foo>*" under MyISAM,
presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
2020-04-09 09:59:53 +12:00
Serge Latyntcev
ac123ee700 Merge branch '4.4' into 4 2019-09-23 16:34:24 +12:00
Serge Latyntcev
4fdcb8180a Merge branch '4.3' into 4.4 2019-09-23 16:22:29 +12:00
Serge Latyntcev
80bcc70d38 Merge branch '4.2' into 4.3 2019-09-23 16:21:50 +12:00
Robbie Averill
6d7cc4f5c0
Merge pull request #2431 from muskie9/pull/pageTypeDropdown#2430
BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
2019-09-16 18:04:23 -07:00
Robbie Averill
a083fc5d5b Merge branch '4.4' into 4 2019-07-19 11:50:38 +02:00
Dylan Wagstaff
68f6eaa663 FIX display recognisable names for dependent content with no title
Content blocks and other DataObjects that contain HTMLText fields are
also used in the 'Dependent pages' report for each page in the CMS,
however these objects may have neither a Title field, nor a name to
describe them. Instead of showing an empty field in the Title column for
this table, we can instead show "Untitled " with the localised singular
name appended.
2019-07-17 15:30:07 +12:00
Sam Minnee
469e7ca01b FIX: Make test comparison less brittle in MigrateSiteTreeLinkingTaskTest
Comparing every single field is unnecessary and brittle, only the IDs
need to be compared.

Notably this tripped over a potential bug fix in
https://github.com/silverstripe/silverstripe-framework/pull/8591
but the change should be incorporated regardless.
2019-05-28 12:51:23 +12:00
Nic Horstmeier
1b3a4aea96 BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
resolves #2430
2019-05-16 19:53:59 -05:00
Loz Calver
7592db918f FIX: VirtualPage missing methods from target page (fixes #2408) 2019-04-18 14:01:26 +01:00
Robbie Averill
79e1b06d17
Merge pull request #2373 from sminnee/search-or-choose-page
MINOR: Change “Choose Page” to “Search or choose Page”
2019-04-17 12:30:46 +12:00
ttunua
0b56a563c0 FIX: Fixes #2110 added default Title value for saved pages. (#2366)
* FIX: Fixes #2110 added default Title value for saved pages.

* FIX: Fixes #2110 fixed linting and unit test failure

* BUG Rename default wording for untitled page
2019-04-15 14:33:15 +12:00
Robbie Averill
d4571d927d Merge branch '4.3' into 4 2019-04-11 11:46:19 +12:00
Serge Latyntcev
de5fc49917 Remove flush from CMSPageHistoryControllerTest
flushing in tests is futile
2019-04-01 10:58:53 +13:00
Robbie Averill
abd661bfab SiteTreeTest::testReadArchiveDate() now tests ORM results rather than underlying sql arguments 2019-02-11 14:30:25 +03:00
Robbie Averill
c1c9d7706a Merge branch '4.3' into 4 2019-02-06 22:25:40 +03:00
Robbie Averill
23ae682b35 Merge branch '4.2' into 4.3 2019-02-06 22:24:53 +03:00
Robbie Averill
976bbc1014 Merge branch '4.1' into 4.2 2019-02-06 22:24:32 +03:00
Robbie Averill
668670b5a1 Merge branch '4.0' into 4.1 2019-02-06 22:24:14 +03:00
Ingo Schommer
5c3b95ac89 FIX Multibyte URL routing
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
2019-02-05 16:45:28 +03:00
Robbie Averill
ff458810ea Automated phpcs linting updates 2019-02-05 16:45:11 +03:00
Guy Marriott
97ee18d463
Merge pull request #2382 from creative-commoners/pulls/4.4/remove-add-to-campaign-button
FIX Remove coupling from SiteTree to campaign admin module
2019-02-04 22:20:35 +13:00
Ingo Schommer
c61ba88d82 FIX Multibyte URL routing
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
2019-02-04 22:02:15 +13:00
Robbie Averill
1a7b23a21f FIX URL segment generation tests for resources dir are now accurate 2019-02-02 13:27:24 +03:00
Robbie Averill
3dbca48d29 Remove assertions for addtocampaign action 2019-02-01 20:20:40 +03:00
Maxime Rainville
ed0680a264 MINOR Add unit test for MetaComponents 2019-02-01 19:48:47 +03:00
Maxime Rainville
53374d617e
Merge pull request #2280 from creative-commoners/pulls/4.2/subsites-namespace
FIX Use correct subsites namespace in SiteTree and test classes
2019-02-01 17:27:35 +13:00
Sam Minnee
dd06178167 MINOR: Change “Choose Page” to “Search or choose Page”
Based on discussions with James Ford, it wasn’t clear that you could
search.

Companion to https://github.com/silverstripe/silverstripe-framework/pull/8766
2019-01-29 12:15:38 +13:00
Maxime Rainville
bbffe05541 Fixing linting error. 2019-01-12 00:16:04 +13:00
Maxime Rainville
3a1329f61b MINOR Clean up CMSMain::CanOrganiseSitetree 2019-01-11 23:56:40 +13:00
Aaron Carlino
75f41b56d5 Merge branch '4.3' into 4 2019-01-10 14:57:01 +13:00
Aaron Carlino
0e8b87087d Merge branch '4.2' into 4.3 2019-01-10 14:56:15 +13:00
Aaron Carlino
9ccba1b0bb Merge branch '4.1' into 4.2 2019-01-10 14:49:25 +13:00
Aaron Carlino
06b982f8dc MINOR: Fix linting error 2019-01-10 14:10:47 +13:00
Aaron Carlino
6beb682cfa Merge branch '4.3' into 4 2019-01-10 12:06:36 +13:00
Maxime Rainville
345f6fcef8 MINOR Update CMS test to work with configurable resource dir (#2353) 2019-01-09 15:35:59 +13:00
Guy Marriott
5269036e93
Merge pull request #2346 from open-sausages/pulls/4.3/fix-form-clearing
Add test to make sure you can create a page under another page
2018-12-12 18:11:22 +13:00
Aaron Carlino
b83d818e0a Merge branch '4.2' into 4.3 2018-12-11 17:07:55 +13:00
Aaron Carlino
acc7f46b02 Merge branch '4.1' into 4.2 2018-12-11 11:42:35 +13:00
Aaron Carlino
a4b78c4041 Merge branch '4.0' into 4.1 2018-12-11 11:42:11 +13:00
Guy Marriott
c1b1572752
Merge pull request #2344 from creative-commoners/pulls/4.3/unsaved-dependent-relations
FIX Unsaved SiteTree records now return an empty list for DependentPages
2018-12-03 11:48:54 +13:00
Robbie Averill
7554b61325 Update meta generator tests to use isolated configuration and better assertions 2018-12-02 18:20:44 +00:00
Robbie Averill
602597b900 FIX CMSPageHistoryControllerTest now uses a stub controller to avoid URL conflicts with versioned-admin 2018-12-02 18:07:56 +00:00
Robbie Averill
29a22bcb52
Set history controller priority in tests to ensure it is loaded 2018-12-02 15:57:26 +00:00
bergice
53cd9dcf1c Add test to make sure you can create a page under another page 2018-11-30 13:28:04 +13:00
Robbie Averill
0bb22732c9 FIX Unsaved SiteTree records now return an empty list for DependentPages 2018-11-28 13:44:52 +01:00
Robbie Averill
ce3a1ce913 FIX Use correct subsites namespace in SiteTree and test classes 2018-11-20 13:34:38 +01:00
Sam Minnee
5e3068ba13 MINOR: Add tests for some search-form fixes
These 2 tests validate that the following bugs have been fixed.

https://github.com/silverstripe/silverstripe-framework/issues/3212
https://github.com/silverstripe/silverstripe-cms/issues/1452
2018-11-10 12:07:49 +13:00
Robbie Averill
ab739c7fb0 FIX Replace usage of Convert JSON methods with json_encode and json_decode 2018-10-28 21:21:19 +00:00
Maxime Rainville
f08be7217a MINOR Update CMS test to explicitetly register the CMSPageHistoryController (#2300) 2018-10-24 15:16:54 +13:00
Maxime Rainville
9abd721a56 MINOR Update CMS test to explicitetly register the CMSPageHistoryController (#2300) 2018-10-24 15:13:59 +13:00
Robbie Averill
b3013a98c4 Update testSearchField to expect namespaced search fields 2018-10-01 12:50:20 +02:00
Robbie Averill
44b92c90bc FIX Update field names in Behat tests for new search form namespacing 2018-09-27 11:39:42 +02:00
Luke Edwards
41c0b8fb85 Fix 'Insert links into a page' test 2018-09-12 13:14:06 +12:00
Luke Edwards
f3da10119e Disable page search test scenarios involving date due to bug 2018-09-07 12:11:57 +12:00
Luke Edwards
2fbeda1564
ADD New search component for SiteTree (#2224) 2018-09-04 13:13:33 +12:00