Commit Graph

3711 Commits

Author SHA1 Message Date
Ingo Schommer
dbb645cde6 elofgren: BUGFIX: Make adding a newsletter type to the 'Newsletters' tree work when a draft is selected by changing the name of the 'NewsletterEditForm?' back to 'EditForm?' (reverts r36734 which was a fix to make the 'Save changes' button work on the now non-existant modal 'Usaved changes' dialog.) In addition this commit reverts r37173 because the form name is now 'EditForm?' like all other forms in NewsletterAdmin?.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:53:38 +00:00
Ingo Schommer
318bae74f6 elofgren: Newsletters: Remove reference to Form_NewsletterEditForm_Type in NewsletterAdmin?_right.js since the newsletter type form is simply called EditForm? and saving the newsletter type doesn't require check for 'action_savenewsletter' being set.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41852 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:58 +00:00
Ingo Schommer
05a8a40e01 elofgren: BUGFIX: Fix status message displayed after deleting items from the left 'Newsletters' tree. Instead of 'Deleted items', actually give a value to and display it as a number.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:37 +00:00
Ingo Schommer
768862a9e4 elofgren: BUGFIX: Newsletters section: Make unsaved changes confirm() dialogue show when a new selection is made in the left tree by removing the check for the existance of the save() function which was removed in r36869. The save() function used to be called by the old modal 'Unsaved Changes' dialogue when the 'Save changes' button was pressed. The new confirm() dialogue has no 'Save changes' button so the save() function is no longer needed.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:12 +00:00
Ingo Schommer
e2475e8dcd elofgren: BUGFIX: Make adding a newsletter draft to the left site tree work again.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41849 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:47 +00:00
Ingo Schommer
14acd05f1b elofgren: USABILITY: Make 'Go' button be on same line as 'Create a Page' drop-down.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:20 +00:00
Ingo Schommer
e1438c9949 qhoxie: updates to stats panels
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:54 +00:00
Ingo Schommer
dd853ef168 elofgren: USABILITY: Add 'label' tags for 'Compare mode (click 2 below)' and 'Show unpublished versions' checkboxes in left frame 'Page Version History' section.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:11 +00:00
Ingo Schommer
e70d060983 elofgren: USABILITY: In 'Page Version History' left sidebar section, use a checkbox labeled 'Compare mode (click 2 below)' instead of a drop-down with only 'View (click to see)' and 'Compare (click 2 to see)' options. More info: http://www.elijahlofgren.com/silverstripe/inconsistent-go-buttons/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:48 +00:00
Ingo Schommer
d497fbf671 elofgren: VAR FIXES: Add some needed issets() and variable initializations to fix a lot of warnings when comparing 2 versions of a page.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:11 +00:00
Ingo Schommer
9b29b09a24 elofgren: VAR FIX: Fix typo in LeftAndMain::addTreeNodeJS() by renaming 'select' parameter to 'selected' because 'selected' is what is used in the method body.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:51 +00:00
Ingo Schommer
dfa6b99f18 elofgren: VAR FIXES: Fix 2 undefined variable errors in CMSMain::deletefromlive() and 1 in CMSMain::deleteitems() that showed up in status messages while deleting pages.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:22 +00:00
Ingo Schommer
8f980e1e02 elofgren: USABILITY: Add tooltips to pages in 'Site Content' tree showing 'Page type: className' where className is the page's type.
More info: http://www.elijahlofgren.com/silverstripe/icons-missing-from-left-navigation-tree-key/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:42:24 +00:00
Ingo Schommer
5e6fd830e2 elofgren: USABILITY: Fix usability issue #30 'Replace Image button needs repositioning' by adding back the margin, border, and padding around the fieldset and increasing height. More info:
http://www.elijahlofgren.com/silverstripe/replace-image-button-needs-repositioning/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41808 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:51 +00:00
Ingo Schommer
59bfa913a5 elofgren: USABILITY: In 'Site Content' left frame, relabel 'Site Tree' => 'Site Content', 'History' => 'Page Version History', 'Reports' => 'Site Reports' .Fixes usability issue #21: http://www.elijahlofgren.com/silverstripe/site-content-needs-consistent-labeling/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41807 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:22 +00:00
Ingo Schommer
ad3aed7930 mlanthaler: Bugfix: "if($className == null); $className = $this->stat('subitem_class');" had no effect because of the semicolon after the if-statement.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:40:56 +00:00
Ingo Schommer
c2f57b75de mlanthaler: Suppress E_NOTICE when $_REQUESTctf?childID? is not set (e.g. when adding a new member by clicking on "Add member" in the security tab).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41805 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:39:59 +00:00
Ingo Schommer
3ee2969cd5 elofgren: USABILITY: Remove 'Surname', 'FirstName?', and 'Email' from list of 'changeDetection_fieldsToIgnore'. This completes fixes for usability issue #91 "Warning needs to be added for unsaved changes
in Security section". More info: http://www.elijahlofgren.com/silverstripe/warning-needs-to-be-added-for-unsaved-changes-in-security-section/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41804 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:38:25 +00:00
Ingo Schommer
119b3b017a elofgren: USABILITY: Remove the left Side Tabs and implement clicking on the headings to show sidebar sections instead in order to fix Usability issue "#22 Allow clicking on blue heading bar of Left
Site Tree to reduce it". More info: http://www.elijahlofgren.com/silverstripe/allow-clicking-on-blue-heading-bar-of-left-site-tree-to-reduce-it/ 
A big THANK YOU to Andy Skelton for permission to use his WordPress? toggle icons originally posted at: http://trac.wordpress.org/attachment/ticket/1904/toggle.gif 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41803 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:37:48 +00:00
Ingo Schommer
274a3d678c elofgren: Set svn:mime-type=application/octet-stream on psd images in cms/images/sidetabs so they won't show up in diffs when they are deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41802 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:34:34 +00:00
Ingo Schommer
8fe47c6e87 qhoxie: basic setup for statistics viewing and handling in the cms
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:33:51 +00:00
Ingo Schommer
7f61325204 elofgren: Remove unused code: 1. doYouWantToSave() that called OpenModalDialog?() has been replaced by a call to confirm() 2. CMSMain::savedialog() which was the PHP part of the old modal save dialog. 3. save() in NewsletterAdmin?_right.js which seems to have been replaced by the save function of Form_EditForm
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41800 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:32:19 +00:00
Ingo Schommer
93ae866e60 elofgren: USABILITY: Make Newsletter section use new js confirm dialog instead of old modal one. More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:30:54 +00:00
Ingo Schommer
f7ed6b050f elofgren: USABILITY: 1. Always use confirmation when calling autoSave, not just for 'Microsoft Internet Explorer' since the new confirm() dialog works in all browsers.
2. Make MainMenu? links call LeftAndMain?_window_unload() to check for unsaved changes before loading new page. Don't register LeftAndMain?_window_unload with window 'beforeunload' event because it 
cannot stop the page unload and the save check is now done via links (where stopping the unload works). 
3. Make external Logo link open in a new window like the Menu-help link to prevent unsaved changes being lost. 
More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/ (merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41798 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:30:11 +00:00
Ingo Schommer
b1173b174b elofgren: Add back options save code deleted in r36865 because it is used if confirmation=false
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:29:12 +00:00
Ingo Schommer
067d630e06 elofgren: USABILITY: Use a confirm() javascript dialog box instead of the slow loading modal one for asking user if they want to save their changes when they click on a new page in the left tree. More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41796 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:28:41 +00:00
Ingo Schommer
9792c6bf37 elofgren: Add ellipsis (...) to Newsletter Send button to be consistent with 'Move Files...' button.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41795 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:28:03 +00:00
Ingo Schommer
8be38885d0 elofgren: USABILITY: Fix usability issue #66 'Cancel button needs to be added to Send Newsletter Window' by adding a Cancel button and aligning it left.
More info here: http://www.elijahlofgren.com/silverstripe/cancel-button-needs-to-be-added-to-send-newsletter-window/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41794 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:27:34 +00:00
Ingo Schommer
74214051b8 mlanthaler: Changed the login messages to reflect the fact that more authentication methods are available.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:26:56 +00:00
Ingo Schommer
19e222b5c2 elofgren: BUGFIX: In NewsletterAdmin::getNewsletterEditForm() use 'NewsletterEditForm?' instead of 'EditForm?' as the name of the form so that clicking 'Save changes' in the 'Unsaved Changes' reminder popup will actually save the Newsletter draft. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:12:42 +00:00
Ingo Schommer
4c0681927d elofgren: Instead of setting className= in NewsletterAdmin?'s save() and savenewsletter() functions (in order to fix an undefined variable problem earlier), set it to 'NewsletterType?' in save() and 'Newsletter' in savenewsletter(), and then use those values in both calls to DataObject::get_one() (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:12:00 +00:00
Ingo Schommer
1eca17e0a9 elofgren: USABILITY: Rework the tabs in the Newsletter section to be less confusing as per issue #57 of the Usability Report
Includes the removal of all tabs and submit action buttons when 'Drafts' or 'Sent Items' are clicked and the addition of an 'add one' link on 'Drafts' folder page. 
For more information see: http://www.elijahlofgren.com/silverstripe/newletter-tree-and-tab-row-are-confusing/ 
Includes a few fixes for undefined variables.  (merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41772 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:29:08 +00:00
Ingo Schommer
9a229d70a5 mujma: USABILITY: Fixed usability issue number #46. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:33:58 +00:00
Ingo Schommer
18cde3fb7d mujma: USABILITY: Fixed usability issue number #43. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:32:55 +00:00
Ingo Schommer
83bc91db7f mujma: BBUGFIX: Save button is now on right hand side. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:20:42 +00:00
Ingo Schommer
1bff08f5d2 wscott: The cms will now ping google with sitemap updates when pages are published or unpublished (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:19:13 +00:00
Ingo Schommer
e3fee8edf6 wscott: Added comment to _config.php (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:01:48 +00:00
Sean Harvey
4301f7b29f added a message to indicate there are no widgets available
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41492 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-09 11:28:26 +00:00
Andrew O'Neil
0538bc2595 Add back the lines deleted in r41205
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-07 00:20:22 +00:00
Sam Minnee
1bd7dce68a Refactored CMS page-URL accessing to use ->AbsoluteLink(), which can be overridden by defining alternateAbsoluteLink()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41283 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-05 06:42:26 +00:00
Sam Minnee
df2b2f695a Added SiteTreeHandlers.controller_url so that subsites module can work
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41219 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-04 04:12:30 +00:00
Romain Louis
e7a56ece26 RelationComplexTableField.js and GalleryPage_CMS.js requirements adding
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41203 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-04 03:42:59 +00:00
Sam Minnee
1739d9932a Added EDIT_PERMISSIONS permission code for SecurityAdmin
Added LeftAndMain::alternateAccessCheck() / alternateMenuDisplayCheck() so that subsite could hook a new security model into the admin
Added support for Group::alternateTreeTitle() to allow subsites to put *s before global groups

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41098 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-31 00:31:49 +00:00
Sam Minnee
62c2237773 Improved ingize() support so that it works on multi-word verbs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40997 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-28 22:03:18 +00:00
Sam Minnee
6c4a2e24aa Refactored newsletter system to put recipient selection and form-fieldset generation into the NewsletterType class, to allow for subclassing NewsletterType to create special system newsletters. [see oriwave2 for an example]
Removed a number of notice-level errors.
Allowed for BOUNCE_EMAIL to not exist and bounce-handling to be disabled.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40963 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-28 01:55:45 +00:00
Sam Minnee
281009b00f Removing notice-level errors
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-27 05:07:43 +00:00
Sam Minnee
b747f9c42e Moved callPageMethod to leftandmain, so that I can use it in other CMS controllers
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-27 05:06:57 +00:00
Normann Lou
628105c410 add more strict condition inside getNewletterTypeEditForm to make NewsleterAdmin more robust.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-24 03:50:17 +00:00
Normann Lou
48939b8102 add an unsubscribe record when member unsubscribe a newsletter.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40811 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-24 03:37:51 +00:00
Normann Lou
23a2a46532 enable validation to GenericDataAdmin form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@40754 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-08-23 05:45:41 +00:00