Hello @robbieaverill, please check my assumption...it's been a long time since I have last used SS (v3.2 was my last, if i remember correctly)
in the following lines 438:
```php
if (isset($this->templates[$action]) && $this->templates[$action]
|| (isset($this->templates['index']) && $this->templates['index'])
|| $this->template
) {
return parent::getViewer($action);
}
```
it looks like the 1st two (same-line) condition should be wrapped inside `()` while checking for a non-index action template .... if not just kill this PR at once. :-)
if the answer is yes then we can just use `!empty(...)` which is the same as 'isset(...) + truthy check'
kind regards,
maks
* Various refactoring to support viewing list view in context menu and suppressed tree node
* Bugfixes per Maxime review
* Fix URL param collision
* Fix show in list on detail view
* Remove AJAX for show in list. Use hard refresh to keep URL state
Squashed commit of the following:
commit 6ee00358f70e26ef5faf622b8f23fc4419698ed5
Author: Maxime Rainville <maxime@silverstripe.com>
Date: Wed Jul 11 13:22:07 2018 +1200
Remove debug statement.
commit 8e80300244a19e84d638ffd151b236b846c35b77
Author: Luke Edwards <luke@silverstripe.com>
Date: Wed Jul 11 10:55:04 2018 +1200
Only remove actions for readonly rather than only display link
commit 1d3693432bb1ca403d3eefc648cfddb8372b82bd
Author: Luke Edwards <luke@silverstripe.com>
Date: Wed Jul 11 09:12:21 2018 +1200
Stop button wrapping when 'Cancel' is longer in another language
commit 5495992b22a0546aaa87e5ea1b2fa9c79f6e119d
Author: Luke Edwards <luke@silverstripe.com>
Date: Tue Jul 10 16:02:27 2018 +1200
Use link as the readonly representation of the URLSegment
commit 5737e152424281dbea480872900d735cc43f5fd3
Author: Luke Edwards <luke@silverstripe.com>
Date: Mon Jun 18 11:07:34 2018 +1200
Improve readonly styling of URLSegement field
commit 272da9361452843fbb368bfc67e13e6d9540faf2
Author: Luke Edwards <luke@silverstripe.com>
Date: Mon Jun 18 10:18:33 2018 +1200
Use input-addon style for URLSegment field
Luke Edwards
Robbie Averill
maks
Robbie Averill
Maxime Rainville
Guy Marriott
Daniel Hensby
root
Daniel Hensby
Ingo Schommer
Will Rossiter
Loz Calver
Maxime Rainville
Aaron Carlino
Raissa North
Damian Mooyman
Dylan Wagstaff