tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

elofgren: USABILITY: Make the 'Site Reports' drop-down use a 'Go' button. Fixes usability issue #12. More info: http://www.elijahlofgren.com/silverstripe/inconsistent-go-buttons/

Browse Source 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41885 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Ingo Schommer 2007-09-15 01:15:08 +00:00
parent cc26ae1dd4
commit 3fc2fc14ec
3 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
css/cms_left.css
View File

@ -38,7 +38,7 @@
width: 75%; width: 75%;
margin: 0; margin: 0;
} }
#PageType { #ReportSelector_holder select, #PageType {
width: 75%; width: 75%;
float: left; float: left;
margin-right: 3px; margin-right: 3px;
@ -278,9 +278,6 @@ ul.tree span.modified,
margin: 0; margin: 0;
padding: 3px; padding: 3px;
} }
#ReportSelector_holder select {
width: 100%;
}
#treepanes .pane_actions { #treepanes .pane_actions {
margin: 7px 4px; margin: 7px 4px;

12
javascript/SideReports.js
View File

@ -37,14 +37,14 @@ SideReports.prototype = {
} }
SideReportDropdown = Class.create(); SideReportGo = Class.create();
SideReportDropdown.prototype = { SideReportGo.prototype = {
destroy: function() { destroy: function() {
this.onchange = null; this.onclick = null;
this.holder = null; this.holder = null;
}, },
onchange: function() { onclick: function() {
this.holder.showreport(); $('reports_holder').showreport();
} }
} }
@ -65,6 +65,6 @@ SideReportRecord.prototype = {
} }
} }
SideReportDropdown.applyTo('#ReportSelector'); SideReportGo.applyTo('#report_select_go');
SideReportRecord.applyTo('#reports_holder a'); SideReportRecord.applyTo('#reports_holder a');
SideReports.applyTo('#reports_holder'); SideReports.applyTo('#reports_holder');

2
templates/Includes/CMSMain_left.ss
View File

@ -129,7 +129,7 @@
Site Reports Site Reports
</h2> </h2>
<div class="listpane" id="reports_holder" style="display:none"> <div class="listpane" id="reports_holder" style="display:none">
<p id="ReportSelector_holder">$ReportSelector</p> <p id="ReportSelector_holder">$ReportSelector <input class="action" type="submit" id="report_select_go" value="Go" /></p>
<div class="unitBody"> <div class="unitBody">
</div> </div>
</div> </div>