From 3fc2fc14ec90ef97b94ebe3760478b025475ad51 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Sat, 15 Sep 2007 01:15:08 +0000
Subject: [PATCH] elofgren: USABILITY: Make the 'Site Reports' drop-down use a
 'Go' button. Fixes usability issue #12. More info:
 http://www.elijahlofgren.com/silverstripe/inconsistent-go-buttons/ (merged
 from branches/gsoc)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41885 467b73ca-7a2a-4603-9d3b-597d59a354a9
---
 css/cms_left.css                   |  5 +----
 javascript/SideReports.js          | 12 ++++++------
 templates/Includes/CMSMain_left.ss |  2 +-
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/css/cms_left.css b/css/cms_left.css
index 26d52a9d..29dd57fe 100644
--- a/css/cms_left.css
+++ b/css/cms_left.css
@@ -38,7 +38,7 @@
 	width: 75%;
 	margin: 0;
 }
-#PageType {
+#ReportSelector_holder select, #PageType {
 	width: 75%;
 	float: left;
 	margin-right: 3px;
@@ -278,9 +278,6 @@ ul.tree span.modified,
 	margin: 0;
 	padding: 3px;
 }
-#ReportSelector_holder select {
-	width: 100%;
-}
 
 #treepanes .pane_actions {
 	margin: 7px 4px;
diff --git a/javascript/SideReports.js b/javascript/SideReports.js
index 64063ef5..3d3fed93 100755
--- a/javascript/SideReports.js
+++ b/javascript/SideReports.js
@@ -37,14 +37,14 @@ SideReports.prototype = {
 	
 }
 
-SideReportDropdown = Class.create();
-SideReportDropdown.prototype = {
+SideReportGo = Class.create();
+SideReportGo.prototype = {
 	destroy: function() {
-		this.onchange = null;
+		this.onclick = null;
 		this.holder = null;
 	},
-	onchange: function() {
-		this.holder.showreport();
+	onclick: function() {
+		$('reports_holder').showreport();
 	}
 }
 
@@ -65,6 +65,6 @@ SideReportRecord.prototype = {
 	}
 }
 
-SideReportDropdown.applyTo('#ReportSelector');
+SideReportGo.applyTo('#report_select_go');
 SideReportRecord.applyTo('#reports_holder a');
 SideReports.applyTo('#reports_holder');
\ No newline at end of file
diff --git a/templates/Includes/CMSMain_left.ss b/templates/Includes/CMSMain_left.ss
index eeaf34cf..ccaa25ab 100755
--- a/templates/Includes/CMSMain_left.ss
+++ b/templates/Includes/CMSMain_left.ss
@@ -129,7 +129,7 @@
 			Site Reports
 		</h2>
 		<div class="listpane" id="reports_holder" style="display:none">
-			<p id="ReportSelector_holder">$ReportSelector</p>
+			<p id="ReportSelector_holder">$ReportSelector <input class="action" type="submit" id="report_select_go" value="Go" /></p>
 			<div class="unitBody">
 			</div>
 		</div>