tonyair/silverstripe-blog
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-blog synced 2024-10-22 11:05:58 +02:00
Code Issues Projects Releases Wiki Activity

FIX If grant_user_access is set then return filtered list

Browse Source 
I think there is a bug here in that a config value doesn't actually filter the returned Members. This causes a problem on large sites with 1000's of users as it returns them all and you often run into a out of memory problem. I should be able to set a permission value which qualifies a list of appropriate users that can manage blog roles.

Is it as simple as reversing the conditional?
This commit is contained in:
Cam Findlay 2015-10-29 21:41:50 +13:00
parent dde32209f8
commit e804330218
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/model/Blog.php
View File

@ -360,11 +360,11 @@ class Blog extends Page implements PermissionProvider {
*/ */
protected function getCandidateUsers() { protected function getCandidateUsers() {
if($this->config()->grant_user_access) { if($this->config()->grant_user_access) {
return Member::get();
} else {
return Permission::get_members_by_permission( return Permission::get_members_by_permission(
$this->config()->grant_user_permission $this->config()->grant_user_permission
); );
} else {
return Member::get();
} }
} }