tonyair/silverstripe-blog
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-blog synced 2024-10-22 11:05:58 +02:00
Code Issues Projects Releases Wiki Activity

FIX: Unit test for BlogPostNotifications identified a missing %s in a sprintf statement, meaning the title of a BlogPost would not show in the subject of a notification email

Browse Source
This commit is contained in:
Gordon Anderson 2016-01-25 18:23:27 +07:00
parent 694b41176a
commit 687406dea8
2 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/extensions/BlogPostNotifications.php
View File

@ -27,6 +27,6 @@ class BlogPostNotifications extends DataExtension
*/
public function updateNotificationSubject(&$subject, &$comment, &$recipient)
{
$subject = sprintf('A new comment has been posted on ', $this->owner->Title);
$subject = sprintf('A new comment has been posted on %s', $this->owner->Title);
}
}

52
tests/BlogPostNotificationsTest.php Normal file
View File

@ -0,0 +1,52 @@
<?php
class BlogPostNotificationsTest extends SapphireTest
{
/**
* @var string
*/
public static $fixture_file = 'blog.yml';
public function testUpdateNotificationRecipients()
{
if (!class_exists('CommentNotifier')) {
$this->markTestSkipped('Comments Notification module is not installed');
}
$blogPost = $this->objFromFixture('BlogPost', 'PostC');
$comment = new Comment();
$comment->Comment = 'This is a comment';
$comment->write();
$recipients = $blogPost->notificationRecipients(
$comment
)->toArray();
$segments = array();
foreach ($recipients as $recipient) {
array_push($segments, $recipient->URLSegment);
}
sort($segments);
$this->assertEquals(array('blog-contributor', 'blog-editor',
'blog-writer', ), $segments);
}
public function testUpdateNotificationSubject()
{
if (!class_exists('CommentNotifier')) {
$this->markTestSkipped('Comments Notification module is not installed');
}
$blogPost = $this->objFromFixture('BlogPost', 'PostC');
$comment = new Comment();
$comment->Comment = 'This is a comment';
$comment->write();
$recipients = $blogPost->notificationRecipients(
$comment
)->toArray();
$subject = $blogPost->notificationSubject($comment, $recipients[0]);
$this->assertEquals(
'A new comment has been posted on Third Post',
$subject
);
}
}