tonyair/silverstripe-blog
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-blog synced 2024-10-22 11:05:58 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: comment improvements and fixes

Browse Source
This commit is contained in:
Will Rossiter 2008-12-04 21:34:49 +00:00
parent cb0ca458e3
commit 3f50a8e36c
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
code/TagCloudWidget.php
View File

@ -52,17 +52,17 @@ class TagCloudWidget extends Widget {
if($entries) { if($entries) {
foreach($entries as $entry) { foreach($entries as $entry) {
$theseTags = split(" *, *", trim($entry->Tags)); $theseTags = split(" *, *", strtolower(trim($entry->Tags)));
foreach($theseTags as $tag) { foreach($theseTags as $tag) {
$allTags[$tag] = isset($allTags[$tag]) ? $allTags[$tag] + 1 : 1; //getting the count into key => value map if($tag != "") {
$max = ($allTags[$tag] > $max) ? $allTags[$tag] : $max; $allTags[$tag] = isset($allTags[$tag]) ? $allTags[$tag] + 1 : 1; //getting the count into key => value map
$max = ($allTags[$tag] > $max) ? $allTags[$tag] : $max;
}
} }
} }
if($allTags) { if($allTags) {
//TODO: move some or all of the sorts to the database for more efficiency //TODO: move some or all of the sorts to the database for more efficiency
if($this->Limit > 0){ if($this->Limit > 0){
uasort($allTags, "column_sort_by_popularity"); //sort by popularity uasort($allTags, "column_sort_by_popularity"); //sort by popularity
$allTags = array_slice($allTags, 0, $this->Limit); $allTags = array_slice($allTags, 0, $this->Limit);
@ -112,7 +112,6 @@ class TagCloudWidget extends Widget {
"Link" => $blogHolder->Link() . 'tag/' . urlencode($tag) "Link" => $blogHolder->Link() . 'tag/' . urlencode($tag)
); );
} }
} }
$output = new DataObjectSet(); $output = new DataObjectSet();
@ -126,15 +125,19 @@ class TagCloudWidget extends Widget {
} }
} }
/**
* Helper method to compare 2 Vars to work out the results.
* @param mixed
* @param mixed
* @return int
*/
function column_sort_by_popularity($a, $b){ function column_sort_by_popularity($a, $b){
if($a == $b) { if($a == $b) {
$result = 0; $result = 0;
} }
else { else {
$result = $b - $a; $result = $b - $a;
} }
return $result; return $result;
} }