tonyair/silverstripe-behat-extension
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-behat-extension synced 2024-10-22 17:05:32 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #103 from silverstripe-labs/revert-96-patch-detect-404

Browse Source 
Revert "ENH: adding wrapper around visit to detect 404s"
This commit is contained in:
Ingo Schommer 2016-01-26 09:20:31 +13:00
commit c424b5f1fa
1 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/SilverStripe/BehatExtension/Context/SilverStripeContext.php
View File

@ -497,26 +497,5 @@ class SilverStripeContext extends MinkContext implements SilverStripeAwareContex
EOS;
$this->getSession()->getDriver()->executeScript($script);
}
/**
* @Override "When /^(?:|I )go to "(?P<page>[^"]+)"$/"
* We override this function to detect issues with .htaccess external redirects.
*
* For instance, if the behat test is being run with a base_url which includes a
* path, e.g. "http://localhost/behat-test-abc123/", .htaccess redirects may take the browser
* to the wrong base path, e.g. "http://localhost/", which will then probably generate
* a apache 404 response, which is pretty standard and we can detect it and give a better
* error message.
*/
public function visit($page){
parent::visit($page);
// We now check the response body. We would check for the response status code,
// but that is not quite possible yet, so this is the best we can do.
$page = $this->getSession()->getPage();
$title = $page->find('css', 'title')->getHtml(); // getText returns empty string, so have to use getHtml
assertNotEquals('404 Not Found', $title, 'A 404 response was detected from the server. If you intended to test an apache 404 response, please write a specific 404 test step.');
}
}