From ae7b16308efee2d8e110edb4317b3995318dda76 Mon Sep 17 00:00:00 2001 From: Damian Mooyman Date: Mon, 25 Jan 2016 17:55:03 +1300 Subject: [PATCH] Revert "ENH: adding wrapper around visit to detect 404s" --- .../Context/SilverStripeContext.php | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/src/SilverStripe/BehatExtension/Context/SilverStripeContext.php b/src/SilverStripe/BehatExtension/Context/SilverStripeContext.php index 0e9aa94..a35080c 100644 --- a/src/SilverStripe/BehatExtension/Context/SilverStripeContext.php +++ b/src/SilverStripe/BehatExtension/Context/SilverStripeContext.php @@ -497,26 +497,5 @@ class SilverStripeContext extends MinkContext implements SilverStripeAwareContex EOS; $this->getSession()->getDriver()->executeScript($script); } - - - /** - * @Override "When /^(?:|I )go to "(?P[^"]+)"$/" - * We override this function to detect issues with .htaccess external redirects. - * - * For instance, if the behat test is being run with a base_url which includes a - * path, e.g. "http://localhost/behat-test-abc123/", .htaccess redirects may take the browser - * to the wrong base path, e.g. "http://localhost/", which will then probably generate - * a apache 404 response, which is pretty standard and we can detect it and give a better - * error message. - */ - public function visit($page){ - parent::visit($page); - - // We now check the response body. We would check for the response status code, - // but that is not quite possible yet, so this is the best we can do. - $page = $this->getSession()->getPage(); - $title = $page->find('css', 'title')->getHtml(); // getText returns empty string, so have to use getHtml - assertNotEquals('404 Not Found', $title, 'A 404 response was detected from the server. If you intended to test an apache 404 response, please write a specific 404 test step.'); - } - + }