Fix: tagging did not work on facebook
This commit is contained in:
parent
ee770f4610
commit
6d5c75cfbd
@ -431,14 +431,19 @@ browser.contextMenus.onClicked.addListener(function (info, tab) {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
var tabId = tab.id;
|
||||||
|
var frameId = info.frameId;
|
||||||
|
|
||||||
var label = info.menuItemId.substring('mark-'.length);
|
var label = info.menuItemId.substring('mark-'.length);
|
||||||
if (label == 'none') label = '';
|
if (label == 'none') label = '';
|
||||||
browser.tabs.sendMessage(tab.id, {
|
browser.tabs.sendMessage(tabId, {
|
||||||
mark: label,
|
mark: label,
|
||||||
url: info.linkUrl,
|
url: info.linkUrl,
|
||||||
|
tabId: tabId,
|
||||||
|
frameId: frameId,
|
||||||
// elementId: info.targetElementId,
|
// elementId: info.targetElementId,
|
||||||
debug: overrides.debug
|
debug: overrides.debug
|
||||||
}, null, response => {
|
}, { frameId: frameId }, response => {
|
||||||
if (!response.identifier) return;
|
if (!response.identifier) return;
|
||||||
if (response.mark){
|
if (response.mark){
|
||||||
if (badIdentifiers[response.identifier]) return;
|
if (badIdentifiers[response.identifier]) return;
|
||||||
@ -447,7 +452,8 @@ browser.contextMenus.onClicked.addListener(function (info, tab) {
|
|||||||
}
|
}
|
||||||
if (response.debug && /^facebook\.com\/[a-zA-Z]/.test(response.identifier))
|
if (response.debug && /^facebook\.com\/[a-zA-Z]/.test(response.identifier))
|
||||||
alert('Note: could not find numeric id for ' + response.identifier);
|
alert('Note: could not find numeric id for ' + response.identifier);
|
||||||
response.tabId = tab.id;
|
response.tabId = tabId;
|
||||||
|
response.frameId = frameId;
|
||||||
saveLabel(response);
|
saveLabel(response);
|
||||||
})
|
})
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user