From 6d5c75cfbdf9adb60272a3a82ce9e46a40341543 Mon Sep 17 00:00:00 2001 From: shinigami-eyes <43276258+shinigami-eyes@users.noreply.github.com> Date: Fri, 14 Jun 2019 19:03:50 +0200 Subject: [PATCH] Fix: tagging did not work on facebook --- extension/background.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/extension/background.js b/extension/background.js index 876f546..78ce6e1 100644 --- a/extension/background.js +++ b/extension/background.js @@ -431,14 +431,19 @@ browser.contextMenus.onClicked.addListener(function (info, tab) { return; } + var tabId = tab.id; + var frameId = info.frameId; + var label = info.menuItemId.substring('mark-'.length); if (label == 'none') label = ''; - browser.tabs.sendMessage(tab.id, { + browser.tabs.sendMessage(tabId, { mark: label, url: info.linkUrl, + tabId: tabId, + frameId: frameId, // elementId: info.targetElementId, debug: overrides.debug - }, null, response => { + }, { frameId: frameId }, response => { if (!response.identifier) return; if (response.mark){ if (badIdentifiers[response.identifier]) return; @@ -447,7 +452,8 @@ browser.contextMenus.onClicked.addListener(function (info, tab) { } if (response.debug && /^facebook\.com\/[a-zA-Z]/.test(response.identifier)) alert('Note: could not find numeric id for ' + response.identifier); - response.tabId = tab.id; + response.tabId = tabId; + response.frameId = frameId; saveLabel(response); })