dev
84ae9b817e
Adds the unified-review integration that fuses CRG graph context with the ai-code-review scoring methodology and gstack-review fix-first workflow: - scoring.py: objective Layer-2 metrics (sql_risk, exception_coverage, redundancy_rate, high_risk_density, vulnerability_risk) with good/warn/fail grades, plus dedupe_findings (fingerprint merge, multi-source confidence boost, PR quality score) and report data builder - tools/scoring_tools.py + main.py: three new MCP tools (score_review_tool, dedupe_findings_tool, generate_report_tool) - assets/report-template.html: self-contained HTML report template - skills.py + skills/unified-review/: new read-only unified-review skill with language/manual-review/specialist checklists - docs and CHANGELOG updated; tests added (test_scoring, test_report, test_unified_review) and test_skills updated for 5 skills
17 lines
695 B
Markdown
17 lines
695 B
Markdown
# Maintainability Specialist
|
|
|
|
Focus: code quality and maintainability issues.
|
|
|
|
- [ ] Dead code / unreachable branches / unused variables
|
|
- [ ] Magic numbers → named constants
|
|
- [ ] Overcomplicated abstractions (indirection without payoff)
|
|
- [ ] Copy-paste blocks that should be shared (only when it aids clarity)
|
|
- [ ] Functions too large / doing too much
|
|
- [ ] Stale comments contradicting the code
|
|
|
|
Suppress: harmless redundancy that aids readability, comment-on-threshold
|
|
requests, consistency-only changes.
|
|
|
|
Output JSON lines:
|
|
`{"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"maintainability","summary":"...","fix":"...","source":"maintainability"}`
|