Not/srb2k-leaderboard
1
0
Fork 1
Code Issues 2 Pull Requests Projects Releases Wiki Activity

various improvements #2

Closed
Lonsfor wants to merge 0 commits from Lonsfor/srb2k-leaderboard:lonsfor-patch-1 into master
pull from: Lonsfor/srb2k-leaderboard:lonsfor-patch-1
merge into: Not:master
Conversation 3 Commits - Files Changed -
Lonsfor commented 2022-04-30 21:22:33 +00:00
Contributor
Copy Link
Copy Source
No description provided.
Lonsfor added 7 commits 2022-04-30 21:22:33 +00:00
Mmove local cv_teamchange to the top scope de63c4b2be 
No need to constantly look up the cvar when it can be saved
add VoteThinker hook 41b152ccf6
Prevent overflow of minutes e3c870eefd
Dont iterate players if afk is disabled 5790a3c020
Update 'leaderboard.lua' 5080672f7a
dont do an iteration when the player is already known 14f8769d93
only look for scoreTable once 23a8373230
Not commented 2022-05-11 14:00:01 +00:00
Owner
Copy Link
Copy Source

(Thumbs up emoji)

The changes in 5790a3c020 will throw all players into spectator if the lb_afk cvar is flipped on midgame. This was the reason for iterating and setting the afkTime, even when disabled. Using a CV_CALL is sadly not fast enough for preventing this.

I would like a revert or a fix before merging.

(Thumbs up emoji) The changes in 5790a3c020 will throw all players into spectator if the lb_afk cvar is flipped on midgame. This was the reason for iterating and setting the afkTime, even when disabled. Using a CV_CALL is sadly not fast enough for preventing this. I would like a revert or a fix before merging.
Lonsfor commented 2022-05-11 21:52:35 +00:00
Author
Contributor
Copy Link
Copy Source

to be honest, i dont care. like who would turn the akf on in the middle of a race and not on server start.

i think this is better than wasting a full iteration on a feature that you might not want on.

to be honest, i dont care. like who would turn the akf on in the middle of a race and not on server start. i think this is better than wasting a full iteration on a feature that you might not want on.
Not commented 2022-05-12 11:28:15 +00:00
Owner
Copy Link
Copy Source

I agree it's not desirable, but I value consistent expectation of functionality over this negligible performance penalty. You shouldn't question why someone will do something but rather be prepared for it.

I'll apply a fix myself.
Thank you.

I agree it's not desirable, but I value consistent expectation of functionality over this negligible performance penalty. You shouldn't question why someone will do something but rather be prepared for it. I'll apply a fix myself. Thank you.
Not closed this pull request 2022-05-12 11:28:48 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Not
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Not/srb2k-leaderboard#2
Delete Branch "Lonsfor/srb2k-leaderboard:lonsfor-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?