Not/srb2k-leaderboard
1
0
Fork 1
Code Issues 2 Pull Requests Projects Releases Wiki Activity

various improvements #2

Closed
Lonsfor wants to merge 0 commits from Lonsfor/srb2k-leaderboard:lonsfor-patch-1 into master
pull from: Lonsfor/srb2k-leaderboard:lonsfor-patch-1
merge into: Not:master
Conversation 3 Commits - Files Changed -
Lonsfor commented 2022-04-30 23:22:33 +02:00
Contributor
Copy Link
No description provided.
Lonsfor added 7 commits 2022-04-30 23:22:33 +02:00 
No need to constantly look up the cvar when it can be saved
Not commented 2022-05-11 16:00:01 +02:00
Owner
Copy Link

(Thumbs up emoji)

The changes in 5790a3c020 will throw all players into spectator if the lb_afk cvar is flipped on midgame. This was the reason for iterating and setting the afkTime, even when disabled. Using a CV_CALL is sadly not fast enough for preventing this.

I would like a revert or a fix before merging.

(Thumbs up emoji) The changes in 5790a3c020 will throw all players into spectator if the lb_afk cvar is flipped on midgame. This was the reason for iterating and setting the afkTime, even when disabled. Using a CV_CALL is sadly not fast enough for preventing this. I would like a revert or a fix before merging.
Lonsfor commented 2022-05-11 23:52:35 +02:00
Author
Contributor
Copy Link

to be honest, i dont care. like who would turn the akf on in the middle of a race and not on server start.

i think this is better than wasting a full iteration on a feature that you might not want on.

to be honest, i dont care. like who would turn the akf on in the middle of a race and not on server start. i think this is better than wasting a full iteration on a feature that you might not want on.
Not commented 2022-05-12 13:28:15 +02:00
Owner
Copy Link

I agree it's not desirable, but I value consistent expectation of functionality over this negligible performance penalty. You shouldn't question why someone will do something but rather be prepared for it.

I'll apply a fix myself.
Thank you.

I agree it's not desirable, but I value consistent expectation of functionality over this negligible performance penalty. You shouldn't question why someone will do something but rather be prepared for it. I'll apply a fix myself. Thank you.
Not closed this pull request 2022-05-12 13:28:48 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Not/srb2k-leaderboard#2
No description provided.
Delete Branch "Lonsfor/srb2k-leaderboard:lonsfor-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?