Commit Graph

1804 Commits

Author SHA1 Message Date
Dev
cd803c8e8b Refactored new offer checking code 2024-07-21 16:16:57 +01:00
HiddenCirno
f555c24709 Complete issues #667 (Possible issue with flea buying) (!382)
Now when a profile create a new offer and another profile buy it, it can work correctly(For example profile A create a offer and profile B buy this offer, now A will receive money from profile B)
and set RagfairOfferHelper.completeOffer to public because TradeHelper now use it to resolve trade between 2 profiles on ragfair

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/382
Co-authored-by: HiddenCirno <2301697863@qq.com>
Co-committed-by: HiddenCirno <2301697863@qq.com>
2024-07-21 15:05:48 +00:00
HiddenCirno
7e06517c8c Fix that charisma skill cannot deduct repeatable quest change cost (!380)
add discount caculation for repeatable quest change, not it can deduct cost with player's charisma skil level(per level 0.1%)

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/380
Co-authored-by: HiddenCirno <2301697863@qq.com>
Co-committed-by: HiddenCirno <2301697863@qq.com>
2024-07-21 12:01:12 +00:00
HiddenCirno
dcb98f7d1b fix free change still deduct trader standing (!379)
Fix that free change repeatable chance quest still deduct trader standing, now it will deduct when player have no access to free change or have no free change counts

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/379
Co-authored-by: HiddenCirno <2301697863@qq.com>
Co-committed-by: HiddenCirno <2301697863@qq.com>
2024-07-21 08:02:44 +00:00
Dev
014826e683 Added nullguard to showQuestItemHandoverMatchError() 2024-07-21 00:14:33 +01:00
Tyfon
ed3e16a94f Add support for flea market dogtag barter requirements (!378)
Trader offers with dogtag barter requirements are currently missing the `level` and `side` properties necessary to qualify them. This data already exists in the assorts, just needed to be sent along with the offer.

I considered updating the `side` property of `Requirement` in `IAddOfferRequestData.ts`, but that field is never used, and the client appears to pass 0 for both (even though 0 is not a valid `side`).

Not sure if this should be going to `master` or `310-dev`?

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/378
Co-authored-by: Tyfon <tyfon7@outlook.com>
Co-committed-by: Tyfon <tyfon7@outlook.com>
(cherry picked from commit ec76a8897f)
2024-07-20 23:41:39 +01:00
Dev
335806bfd8 Localised error message 2024-07-20 13:44:48 +01:00
Dev
727ba83273 Improved accuracy when creating flea offer - store single item price in `` property
Made `unlimited` property optional as its only used by traders
Slightly reduced pack offer chance + made them have more items
2024-07-19 13:45:34 +01:00
Dev
e5a5bf2ee2 Added comments to functions
(cherry picked from commit 59ffc9d886)
2024-07-18 15:54:11 +01:00
Dev
78f6fad21b Added check for stack count below 1 and resets to 1 when handling single items being passed into unstackOfferItems() 2024-07-18 09:19:44 +01:00
Dev
af6d138f3c Safely exit returnPlayerOffer() when no profile is found 2024-07-18 09:18:33 +01:00
Dev
bd5e7b1e62 Improved getTotalStackCountSize 2024-07-17 20:17:12 +01:00
Dev
4b8b3b77a7 Remove unsued properties + improved how user data is stored/generated 2024-07-17 19:30:17 +01:00
Dev
5e3899c426 Improved fillMagazineWithRandomCartridge() logging
(cherry picked from commit f406918bb8)
2024-07-17 12:44:24 +01:00
Dev
13abd077dd Removed debug data 2024-07-16 21:31:23 +01:00
Dev
fd34e7bc84 Fixed items with a stack count > 1 not selling as expected 2024-07-16 21:08:43 +01:00
Kaeno
fcdf537c3b Update JSONs 2024-07-16 15:49:49 +01:00
Dev
bf8a403372 Removed redundant check on unlocking hideout crafts
(cherry picked from commit 433ea6566a)
2024-07-16 11:59:01 +01:00
Cj
00fffa7845 Add method for capping skill progress (!376)
Adds a check to the `ProfileFixerService` to cap skill progress at 5100. This prevents users from going over the cap with applications like profile editor, resulting in potential negative crafting times and other oddities.

Co-authored-by: Cj <161484149+CJ-SPT@users.noreply.github.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/376
Co-authored-by: Cj <cj@noreply.dev.sp-tarkov.com>
Co-committed-by: Cj <cj@noreply.dev.sp-tarkov.com>
2024-07-15 19:34:26 +00:00
chomp
4fd113d00d Fix flea selling issues (!374)
Co-authored-by: Dev <dev@dev.sp-tarkov.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/374
2024-07-15 18:24:23 +00:00
Dev
77da49bb9e Added common weapon crate
(cherry picked from commit 9e1c3304f0)
2024-07-15 11:31:28 +01:00
Dev
815e6e238c Expanded weapon crate fix to include common/rare creates
(cherry picked from commit 111b75d1ab)
2024-07-15 11:31:20 +01:00
Dev
1762f1637d Added exit when flea offer type is not found
(cherry picked from commit c2ccadf110)
2024-07-14 19:49:41 +01:00
Dev
0629958b92 Added getOfferType() to ragfairController
(cherry picked from commit e67f000602)
2024-07-14 19:49:34 +01:00
Dev
35daf8710f Added null protected around RagfairInfo on profile login 2024-07-14 17:21:12 +01:00
Dev
073797a294 Fixed issue with itemFitsInto1By2Slot() classifying all items as unsuitable for a 1x2 slot
(cherry picked from commit d92ec20e9c)
2024-07-13 12:57:40 +01:00
Dev
77b42bfb2f Fixed getBTC() failing when Production area cannot be found 2024-07-13 10:58:46 +01:00
Dev
034c7142fc Added workaround for Ref repeatables not having any description text - force him to use Prapor text instead 2024-07-13 09:33:04 +01:00
Dev
61313dce25 Remove deprecated registerCommandoCommand()
(cherry picked from commit c705127007)
2024-07-12 22:21:15 +01:00
Dev
bf507a766c Removed deprecated ICommandoCommand
(cherry picked from commit 28593d3e9b)
2024-07-12 22:21:01 +01:00
Dev
1298022600 Fixed endpoint casing 2024-07-12 21:16:33 +01:00
CWX
4eeedc4257 Removed unused code and repurposed save endpoint for scav profile saving 2024-07-12 16:29:21 +01:00
Dev
a3b97ff3ef Added nullguards to giveProfileMoney()
(cherry picked from commit f7a617d621)
2024-07-12 09:49:11 +01:00
Dev
64f8e7b7e8 Protected randomiseArmorInsertsDurabilities() from missing mod errors 2024-07-11 11:11:09 +01:00
Dev
e88521fe54 Added ability to blacklist profile from being created in launcher
(cherry picked from commit 5260b16a18)
2024-07-11 09:59:14 +01:00
Dev
0b9e61dcdc Added comments 2024-07-11 09:45:59 +01:00
Dev
f15a0e6f17 Add type to selectedMemberCategory 2024-07-11 09:35:27 +01:00
静穏靄
d31c5f6f09 Add missing property to IUserDialogDetails (!371)
The property is used for Unheard edition accounts to retain their icon on reloading the dialog.

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/371
Co-authored-by: 静穏靄 <seionmoya@noreply.dev.sp-tarkov.com>
Co-committed-by: 静穏靄 <seionmoya@noreply.dev.sp-tarkov.com>
(cherry picked from commit d0f11fd073)
2024-07-11 09:30:10 +01:00
Dev
b0a65cac7f Fixed server build errors from previously merged PR
(cherry picked from commit e1ca9dedc9)
2024-07-11 09:29:16 +01:00
Dev
6a12a3f04d Fixed incorrect starting hp value inside getLowestHpBody() 2024-07-10 16:46:53 +01:00
Dev
134a4a1ff7 Fixed unlocked weapon reward box from hideout craft returning an error when opened 2024-07-10 14:20:35 +01:00
Dev
a53eea239c FIx
Fixed `openRandomLootContainer()` failing when no config values are found for desired random container
2024-07-10 13:48:00 +01:00
Dev
e9d8c02ac2 Improved pack + multi-item player flea offer handling 2024-07-10 11:39:11 +01:00
Dev
ec6c4b05d9 Updated ItemTpl overrides and regenerated enum 2024-07-09 15:11:18 +01:00
Kaeno
96a40eb301 Enable Quest saving when leaving raid as pmc. Modify maxbotpve caps instead of maxbot cap 2024-07-09 14:52:35 +01:00
Dev
121387aa69 Deleted unused endpoints + code 2024-07-09 14:51:57 +01:00
Dev
1c601cc33e Removed unused endpoint + related service 2024-07-09 14:22:01 +01:00
Dev
dd56749ae1 Generate player scav with lowest Hp bodyparts 2024-07-09 12:35:37 +01:00
Kaeno
18af98e86d Remove trailing spaces and fix isPlayerScav check to generate correct health pool 2024-07-09 10:25:24 +01:00
Dev
28b3afef8a Renamed function to improve readability insuranceDictionaryExists() 2024-07-09 10:19:08 +01:00