Azrael1123
7a4b27bbe1
Better fix for SPT-AKI/Issues#417 ( !215 )
...
[The wiki specifies](https://escapefromtarkov.fandom.com/wiki/Scavs#Scav_karma ) that, between 6 and 8, Fence rep is reset to 6 before penalties are applied (i.e. killing someone at 7.5 rep leaves you at 5.9), but the current fix just subtracts a flat 1 reputation instead (i.e. a kill at 7.5 leaves you at 6.4)
this should change that.
Co-authored-by: Azrael <Azrael@noneofyourbusiness.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/215
Co-authored-by: Azrael1123 <azrael1123@noreply.dev.sp-tarkov.com>
Co-committed-by: Azrael1123 <azrael1123@noreply.dev.sp-tarkov.com>
2024-02-07 08:18:18 +00:00
Refringe
42dabc057b
Improved replaceIDs Method in ItemHelper
...
- Implemented deep cloning of input Items to prevent mutation.
- Reordered parameters: Items (required) now precede PMC data (optional).
- Updated method calls to bring them inline with these changes.
2024-02-06 18:39:06 -05:00
Refringe
c29482394b
(More) Simple Parameter Reassignment Issues
...
Addresses some of the simple linting errors regarding the reassignment of function parameters.
2024-02-06 18:35:11 -05:00
Dev
1101927768
Improve fence price calculation code. Prices now take into account removed item mods + mod durability
2024-02-06 20:44:40 +00:00
Dev
b40e41bd3d
Improve sellChance logic
...
Two changes:
Calcualte the quality of an item and its mods, not just root item
Calcualte the average price of an offer using item + mods, not just root item
2024-02-06 15:52:22 +00:00
Dev
5f873e73b8
Move handbook override code into HandbookHelper.hydrate() - changes now apply to ragfair
2024-02-06 12:52:56 +00:00
Dev
62f51be3aa
Improve readability of valid item check
2024-02-06 12:18:41 +00:00
Dev
7bc9fdbe95
Add system to override handbook price, add christmas gift items small/med/large
2024-02-06 12:16:26 +00:00
Dev
c6de12e6f8
Rename variables/comments for clarity
2024-02-06 09:49:51 +00:00
Refringe
3a2b24b9b8
Simple Parameter Reassignment Issues
...
Addresses some of the more simple linting errors regarding the reassignment of function parameters.
2024-02-05 19:03:26 -05:00
Refringe
34121182a1
Biome Linting Issues
...
Fixed some instances of:
- Unordered imports
- Reassigning function parameters
- Modifying values in assignment/return statements
- Array.forEach being used instead of for...of
- Simplified control logic
2024-02-05 19:03:26 -05:00
Dev
d36593ca57
Rework fence service to handle armor/weapons separately,
...
made config work with a weapon/equipment min/max value
Improve price filtering system to work with weapons/equipment
2024-02-05 19:52:46 +00:00
Dev
a04a05996d
Adjust calculateFenceStandingChangeFromKills() to take into account rep loss when fence rep between 6 and 8 or rep > 8
2024-02-05 14:44:31 +00:00
Dev
bf5f3316b1
Rename cloned variables to help with readability
2024-02-05 14:43:46 +00:00
Dev
183e71370a
Reworked buyItem() to use addItemsToStash() to ensure it performs a space check prior to adding any items to stash
2024-02-05 14:07:21 +00:00
Dev
2f673d12b9
Improve weapon/equipment item purchase filtering
2024-02-05 11:38:04 +00:00
Dev
946172d20c
Add additional helmet soft inserts to getSoftInsertSlotIds()
2024-02-05 09:02:58 +00:00
Dev
a2668a9618
Rework insurance to not duplicate items + still return soft_inserts
...
Added missing groin_back to `itemRequiresSoftInserts()`
2024-02-04 22:41:11 +00:00
Dev
193161f786
Fix preset buy searches not filtering items based on search criteria/player level
2024-02-04 09:31:00 +00:00
Dev
4d88b2a94a
Prevent developer profile changes bleeding into non-dev accounts
2024-02-03 23:40:20 +00:00
Dev
d362e17e1b
prevent failQuest() from failing when no repeatable quest is found
2024-02-03 23:10:42 +00:00
Dev
3c371a6c16
Add search criteria filtering to required search
...
Pull out`isDisplayableOffer` from`passesSearchFilterCriteria`
2024-02-03 20:23:26 +00:00
Dev
b6a57553de
Enhance profile template initial trader standing system to be per trader
2024-02-03 15:53:28 +00:00
Dev
164bf08b08
FIx armor filtering code to correctly return non-armored rigs when requested
2024-02-03 14:00:47 +00:00
Dev
8d2eaf2485
Copy over stackobject count from original reward
2024-02-03 12:47:52 +00:00
Dev
0a6a866ae8
Correctly clone and remap default preset before returning
2024-02-03 12:15:20 +00:00
Dev
e3cf4c3c92
Fix starting quest armor rewards not showing correctly
2024-02-03 11:41:30 +00:00
Dev
12a9cb5ded
Fix processReward() incorrectly trying to add mods to armor items without slots
...
Add `itemHasSlots` to itemHelper and consolodate its use across code
2024-02-03 11:00:30 +00:00
Dev
47bedcb526
improve filtering of required item searches on flea - Fixes locked items being shown in search results
...
Improve type usage inside `getRequiredItemsById()`
2024-02-03 10:33:11 +00:00
Kaeno
1c00c2bb13
Keep bonus.value from text_bonus bonuses
2024-02-02 20:11:09 +00:00
Refringe
69a1723646
Fixes Linting Issues
...
- Reorders imports
- Removes unnecessary `else` control statements
- Simplifies some logic
- Converts key access to dot notation
- Converts Array.forEach loops to for...of loops
2024-02-02 15:00:21 -05:00
Refringe
90492f3aa2
Formatting
...
Have you been using the recommended VSCode extensions? ;)
2024-02-02 15:00:21 -05:00
Dev
5136d69050
Implement flea required searching
2024-02-02 19:23:08 +00:00
Dev
83c3cd5f8b
Remove unused function
2024-02-02 17:22:49 +00:00
Dev
034ac83a10
Improve handling of buying less than max stacksize from fence
2024-02-02 15:56:37 +00:00
Dev
8dab47b3fd
Fix selling to trader an amount above stack size causing currency to not stack
2024-02-02 15:35:02 +00:00
Dev
8d59ab7c77
Replace use of dialogueHelper.addDialogueMessage inside sendInsuredItems() with MailSendService.sendMessage()
2024-02-02 11:57:10 +00:00
Dev
d920dceb53
Remove redundant returns from various hideout functions used inside takeProduction()
2024-02-01 12:47:48 +00:00
Dev
44560991b0
Improve handleRecipe()
...
Better handling of item rewards that need to be split into root + child (ammo boxes)
Use `addItemsToStash()`
move `recipe.isEncoded` check to earlier in function
make use of `getItem()` inside `splitStack()` instead of direct db access
2024-02-01 11:23:32 +00:00
Dev
92d949b445
Comment improvements
2024-02-01 10:24:10 +00:00
Dev
8c99b25df0
Rename interface to IOwnerInventoryItems
2024-02-01 09:58:20 +00:00
Dev
1e4d07937b
Update getBTC() to make use of new function
2024-02-01 09:58:04 +00:00
Dev
8d8baec766
Add new addItemsToStash() function to InventoryHelper
2024-02-01 09:48:46 +00:00
Dev
69735b5037
Check inventory has space before adding bitcoins from craft
2024-01-31 23:39:01 +00:00
Dev
95dd27038d
improve accuracy of daily quest system
...
Keep completed dailies inside "activeQuests" array until dailies are refreshed
Adjust post-raid quest handling to ensure previously completed/failed quests keep their original status
2024-01-31 14:38:18 +00:00
Dev
81960a23fe
Fix bitcoins being returned in bundles instead of individually
2024-01-30 13:24:46 +00:00
Dev
d0af930dc9
Fix not being able to collect bitcoins
...
Improved handling of server/client sync when clicking 'get iems' to reduce chance of `no bitcoins to collect` error
2024-01-30 12:16:27 +00:00
Dev
f3ec237674
Fix issue with weapon mod generation flagging mod as incompatible even though it passes compatibility checks
...
Stop trying to fit a mod to a weapon after 8 blocked attempts
Created streamlined mod compatability checker function
2024-01-29 22:41:08 +00:00
Dev
bf7e214b77
Add nullguard to updateFuel() when generator slot has no items array
2024-01-29 16:40:58 +00:00
Dev
099e2cd6f3
Update air filters to correctly calculate time they were being used since last hideout update tick
2024-01-29 16:05:32 +00:00
