470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not return output object from failQuest()

Browse Source
This commit is contained in:
Dev 2024-03-12 21:29:50 +00:00
parent 378bb7fdae
commit fc1a1432ee
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
project/src/controllers/QuestController.ts
View File

@ -997,6 +997,8 @@ export class QuestController
output: IItemEventRouterResponse,
): IItemEventRouterResponse
{
return this.questHelper.failQuest(pmcData, request, sessionID, output);
this.questHelper.failQuest(pmcData, request, sessionID, output);
return output;
}
}

5
project/src/helpers/QuestHelper.ts
View File

@ -677,14 +677,13 @@ export class QuestHelper
* @param failRequest Fail quest request data
* @param sessionID Session id
* @param output Client output
* @returns Item event router response
*/
public failQuest(
pmcData: IPmcData,
failRequest: IFailQuestRequestData,
sessionID: string,
output: IItemEventRouterResponse = null,
): IItemEventRouterResponse
): void
{
// Prepare response to send back to client
if (!output)
@ -716,8 +715,6 @@ export class QuestHelper
}
output.profileChanges[sessionID].quests.push(...this.failedUnlocked(failRequest.qid, sessionID));
return output;
}
/**