From fc1a1432ee428896f531d5d56a0557d80a364c7e Mon Sep 17 00:00:00 2001 From: Dev Date: Tue, 12 Mar 2024 21:29:50 +0000 Subject: [PATCH] Do not return output object from `failQuest()` --- project/src/controllers/QuestController.ts | 4 +++- project/src/helpers/QuestHelper.ts | 5 +---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/project/src/controllers/QuestController.ts b/project/src/controllers/QuestController.ts index c4d72fd4..41a25827 100644 --- a/project/src/controllers/QuestController.ts +++ b/project/src/controllers/QuestController.ts @@ -997,6 +997,8 @@ export class QuestController output: IItemEventRouterResponse, ): IItemEventRouterResponse { - return this.questHelper.failQuest(pmcData, request, sessionID, output); + this.questHelper.failQuest(pmcData, request, sessionID, output); + + return output; } } diff --git a/project/src/helpers/QuestHelper.ts b/project/src/helpers/QuestHelper.ts index 3a212987..d6a607a5 100644 --- a/project/src/helpers/QuestHelper.ts +++ b/project/src/helpers/QuestHelper.ts @@ -677,14 +677,13 @@ export class QuestHelper * @param failRequest Fail quest request data * @param sessionID Session id * @param output Client output - * @returns Item event router response */ public failQuest( pmcData: IPmcData, failRequest: IFailQuestRequestData, sessionID: string, output: IItemEventRouterResponse = null, - ): IItemEventRouterResponse + ): void { // Prepare response to send back to client if (!output) @@ -716,8 +715,6 @@ export class QuestHelper } output.profileChanges[sessionID].quests.push(...this.failedUnlocked(failRequest.qid, sessionID)); - - return output; } /**