470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor of rollForSale()

Browse Source 
Adjusted function to allow for parts of an offer to succeed or fail instead of a binary sell/fail outcome
optimisation: Only calculate selltime if item will be sold
Added additional debug logging
This commit is contained in:
Dev 2023-06-04 16:30:54 +01:00
parent e4fb8cb40d
commit 6e5f4fbce3
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
project/src/helpers/RagfairSellHelper.ts
View File

@ -54,7 +54,7 @@ export class RagfairSellHelper
} }
/** /**
* Determine if the offer being listed will be sold * Get array of item count and sell time (empty array = no sell)
* @param sellChancePercent chance item will sell * @param sellChancePercent chance item will sell
* @param itemSellCount count of items to sell * @param itemSellCount count of items to sell
* @returns Array of purchases of item(s) listed * @returns Array of purchases of item(s) listed
@ -76,10 +76,11 @@ export class RagfairSellHelper
// Value can sometimes be NaN for whatever reason, default to base chance if that happens // Value can sometimes be NaN for whatever reason, default to base chance if that happens
if (isNaN(sellChancePercent)) if (isNaN(sellChancePercent))
{ {
this.logger.warning(`Sell chance was not a number: ${sellChancePercent}, defaulting to ${this.ragfairConfig.sell.chance.base} %`);
sellChancePercent = this.ragfairConfig.sell.chance.base; sellChancePercent = this.ragfairConfig.sell.chance.base;
} }
this.logger.debug(`Rolling for sell ${itemSellCount} items (chance: ${sellChancePercent})`); this.logger.debug(`Rolling to sell ${itemSellCount} items (chance: ${sellChancePercent}%)`);
// No point rolling for a sale on a 0% chance item, exit early // No point rolling for a sale on a 0% chance item, exit early
if (sellChancePercent === 0) if (sellChancePercent === 0)
@ -89,22 +90,26 @@ export class RagfairSellHelper
while (remainingCount > 0 && sellTime < endTime) while (remainingCount > 0 && sellTime < endTime)
{ {
sellTime += Math.max(Math.round(chance / 100 * this.ragfairConfig.sell.time.max * 60), this.ragfairConfig.sell.time.min * 60); const boughtAmount = this.randomUtil.getInt(1, remainingCount);
if (this.randomUtil.getChance100(sellChancePercent)) if (this.randomUtil.getChance100(sellChancePercent))
{ {
const boughtAmount = this.randomUtil.getInt(1, remainingCount); // Passed roll check, item will be sold
sellTime += Math.max(Math.round(chance / 100 * this.ragfairConfig.sell.time.max * 60), this.ragfairConfig.sell.time.min * 60);
result.push({ result.push({
sellTime: sellTime, sellTime: sellTime,
amount: boughtAmount amount: boughtAmount
}); });
this.logger.debug(`offer will sell at ${new Date(sellTime*1000).toLocaleTimeString("en-US")}`); this.logger.debug(`Offer will sell at: ${new Date(sellTime * 1000).toLocaleTimeString("en-US")}`);
}
else
{
this.logger.debug("Offer will not sell");
}
remainingCount -= boughtAmount; remainingCount -= boughtAmount;
} }
}
return result; return result;
} }