From f1c7c5f02c9904cd9cf89347649f8ebff030926c Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 27 Apr 2019 18:48:06 -0700 Subject: [PATCH] Don't emit boxArtLoadComplete on box art load failure to prevent an infinite loop --- app/backend/boxartmanager.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/backend/boxartmanager.cpp b/app/backend/boxartmanager.cpp index 12e95531..fb7c96b0 100644 --- a/app/backend/boxartmanager.cpp +++ b/app/backend/boxartmanager.cpp @@ -89,10 +89,9 @@ QUrl BoxArtManager::loadBoxArt(NvComputer* computer, NvApp& app) void BoxArtManager::handleBoxArtLoadComplete(NvComputer* computer, NvApp app, QUrl image) { - if (image.isEmpty()) { - image = QUrl("qrc:/res/no_app_image.png"); + if (!image.isEmpty()) { + emit boxArtLoadComplete(computer, app, image); } - emit boxArtLoadComplete(computer, app, image); } QUrl BoxArtManager::loadBoxArtFromNetwork(NvComputer* computer, int appId)