fix: code review — 7 issues resolved

(C1) Add dimensionScores/radarData/passed columns to AssessmentSession
(C2) Mock DataSource in service.spec.ts + app.e2e-spec.ts
(C3) Mock AuditLogService in controller.spec.ts
(C4) Rewrite deleteSession tests for dataSource.transaction
(I1) batchDeleteSessions uses transaction with certificate cleanup
(I2) extractDimensionScores reads from session property
(I3/I5) PDF generator supports multi-page + newline splitting
(I4) findOne inside transaction uses deleteCondition
This commit is contained in:
Developer
2026-05-19 10:06:30 +08:00
parent 7f8e7214b3
commit 82a9e75842
7 changed files with 164 additions and 63 deletions
@@ -64,6 +64,15 @@ export class AssessmentSession {
@Column({ type: 'float', name: 'original_score', nullable: true })
originalScore: number;
@Column({ type: 'simple-json', nullable: true, name: 'dimension_scores' })
dimensionScores: Record<string, number>;
@Column({ type: 'simple-json', nullable: true, name: 'radar_data' })
radarData: any;
@Column({ nullable: true })
passed: boolean;
@Column({ type: 'text', name: 'final_report', nullable: true })
finalReport: string;