wwz110/aurak
1
0
Fork 0
forked from hangshuo652/aurak
Code Pull Requests Activity

fix: linkedGroupIds null check in validateRequiredFields

Browse Source 
null !== undefined was true, causing false validation failure on templates
without linked groups. Changed to != null check.
This commit is contained in:
Developer
2026-05-21 11:17:45 +08:00
parent 54762ca299
commit 240aea24aa
5 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/assessment/graph/nodes/interviewer.node.ts
+4 -5
View File
@@ -77,14 +77,13 @@ export const interviewerNode = async (
? `質問 ${currentQuestionIndex + 1}`
: `Question ${currentQuestionIndex + 1}`;
const optionsText = currentQuestion.options.join('\n');
const instruction = isZh
? '请选择一个选项（输入字母 A/B/C/D）'
? '请选择一个选项'
: isJa
? '選択肢から1つ選んでください（A/B/C/Dを入力）'
: 'Please select one option (enter A, B, C, or D)';
? '選択肢から1つ選んでください'
: 'Please select one option';
prompt = `${label}: ${currentQuestion.questionText}\n\n${optionsText}\n\n${instruction}`;
prompt = `${label}: ${currentQuestion.questionText}\n\n${instruction}`;
} else {
const label = isZh
? `问题 ${currentQuestionIndex + 1}`
server/src/assessment/services/template.service.ts
+6 -6
View File
@@ -20,16 +20,16 @@ export class TemplateService {
) {}
private validateRequiredFields(data: {
linkedGroupIds?: string[];
dimensions?: Array<{ name: string; label?: string; weight?: number }>;
linkedGroupIds?: string[] | null;
dimensions?: Array<{ name: string; label?: string; weight?: number }> | null;
}) {
if (data.linkedGroupIds !== undefined) {
if (!Array.isArray(data.linkedGroupIds) || data.linkedGroupIds.length === 0) {
if (data.linkedGroupIds != null && Array.isArray(data.linkedGroupIds)) {
if (data.linkedGroupIds.length === 0) {
throw new BadRequestException('At least one knowledge group must be linked');
}
}
if (data.dimensions !== undefined) {
if (!Array.isArray(data.dimensions) || data.dimensions.length === 0) {
if (data.dimensions != null && Array.isArray(data.dimensions)) {
if (data.dimensions.length === 0) {
throw new BadRequestException('At least one dimension must be defined');
}
for (const d of data.dimensions) {