Commit Graph

61 Commits

Author SHA1 Message Date
Peter Thaleikis 1a55c0599c Fixing bug "must be an Int, column is of type int" 2015-12-10 19:32:09 -04:00
Ed Chipman fae85f04c1 First pass of new page sort method issue #72 2015-09-06 20:45:00 -03:00
UndefinedOffset 81e8fae97a Fixed issue where append to top would not correct the order properly in model admin fixes #71 2015-05-07 12:44:55 -03:00
Dan Brooks c6bd9e1878 Allow installation anywhere by adding yml config 2015-04-13 22:17:21 +01:00
Matthew Hailwood 70512329a1 Allow 'disableSelection' to be disabled 2015-04-07 10:09:06 +12:00
UndefinedOffset b0d1ad1e9c Changed notice for many_many relationships if the extra field is not an int issue #62 2014-10-16 10:25:23 -03:00
ismooth 3dfe104b53 Initial sorting equals sortColumn
After a user has changed sorting order of objects in the list, and when drag&drop is disabled, sorting is made by $default_sort from that DataObjects property or default set by SS. This results in different sorting when checkbox is enabled or disabled what confuses users. This change always sorts the list by $sortColumn, so that user always sees same sorting.
2014-10-03 16:01:27 +02:00
James Cocker e493231556 Fixes fixSortColumn's Random Inital Sorting
When loading a GridField with several new items without a sort order (e.g. after uploading 10 images via GridFieldBulkEditingTools), it would previously apply a seemingly random order to them. This fix ensures that the order applied is the same order as the items were created (or uploaded) in.
2014-08-06 16:34:25 +01:00
Ed Chipman 81886ed81a Replaced use of DataList::where() with DataList::filter() 2014-08-02 13:55:52 -03:00
UndefinedOffset e3895cc5ef Fixed issue #48 where duplicate sort indexes would occur when appending to top instead of the bottom 2013-10-22 10:36:08 -03:00
Ed eb1e736805 Made adjustments to make the changes more flexible
Fixed issue causing SortableGridField to not work on ModelAdmin lists
2013-10-19 14:34:45 -03:00
g4b0 aa222987af Append new items to the top by default 2013-09-04 15:05:28 +02:00
Ed cd20fdf697 Added event methods that allow detection of the sort action being started or completed resolves #39 2013-08-04 12:15:37 -03:00
Ed 830115fa4f Removed extra language that was not needed
Renamed some of the internal actions
2013-07-18 20:54:33 -03:00
Ed 8b10f39dce Fixed issue with 3.1 caused by DataList being full immutable issue #33 2013-07-10 14:24:00 -03:00
Ed f75ebaea34 Improved how the last edit table is found using ClassInfo::baseDataClass() 2013-05-25 20:42:35 -03:00
Ed fc2d17ace5 Improved how the last edit table is found using ClassInfo::baseDataClass() 2013-05-25 20:28:46 -03:00
Ed a44c66dcb9 Fixed issue caused if the LastEdited column is not on the same table as the sort column 2013-05-25 13:35:55 -03:00
Ed 5af07ed75d LastEdited date is now changed when sorting rows Fixes #35 2013-05-24 19:36:26 -03:00
UndefinedOffset 426b6173c6 Better handling of error if the sort column cannot be found in model classes db fields 2013-03-08 14:15:22 -04:00
Sean Harvey c40488a423 Fixing undefined variable $dataList 2013-02-12 15:19:25 +13:00
Ed 7f2a6dc525 Prevent calling fixSortColumn() and saveGridSort() with UnsavedDataLists 2013-02-08 19:47:34 -04:00
Ed fef252975b Formatting fix 2013-02-06 19:44:43 -04:00
Ed 1dba2a911a Fixed issue with 3.1 were the sort order of all items in the list would be modified if one item is detected to have an sort order of 0 2013-02-06 19:38:20 -04:00
unclecheese 1575323037 BUGFIX: Use config layer to check for decorated $db fields 2013-01-31 13:03:33 -05:00
flxbot d26ae08e69 Update code/forms/GridFieldSortableRows.php
fixes the bug mentiond in issue 24
2013-01-27 15:03:24 +01:00
Ed b54e6f12cf Improved updating of sort orders to use raw queries resolves issue 4 2013-01-23 20:11:22 -04:00
Ed fec61f43ad Formatting fixes 2012-12-30 15:11:33 -04:00
Ed 8242816b0f et Fixed compatibility issues with SilverStripe 3.1 (issue #19) 2012-12-28 14:37:25 -04:00
Ed ff188ed1ec Fixed compatibility issues with SilverStripe 3.1 (issue #19) 2012-12-28 14:35:06 -04:00
Ed 1d49529253 Merge remote-tracking branch 'lrcremote/bug-fix' 2012-10-13 12:46:39 -03:00
UndefinedOffset d76ab46764 Corrected formatting 2012-10-12 09:36:45 -03:00
UndefinedOffset bdc7215bbd Added catch to ensure the sort column is an Int or a subclass of the data type Int (fixes #12) 2012-10-12 09:34:01 -03:00
Simon Elvery 62e171a4e3 BUGFIX Make sure it's possible to rename the module's directory without breaking things. 2012-10-01 10:49:44 +10:00
UndefinedOffset b3ca9e8d4f Fixed issue were "No items to sort" would always be sent back 2012-09-10 09:40:54 -03:00
Shea 04c49653a6 BUGFIX renamed the Items array that is sent in post, as it was being overriden by another postvar called Items, containing GridState data. The array of Item Ids used by SortableGridField is now called ItemIDs 2012-09-10 13:38:00 +10:00
Ed 2633ac7ecb Fixed issue 6 2012-08-19 14:43:20 -03:00
UndefinedOffset 35f2a5a463 Consistent Formatting 2012-08-10 12:52:39 -03:00
UndefinedOffset 0beef798a0 Sort order is now always fixed even if drag and drop toggle is not on 2012-08-10 12:50:14 -03:00
UndefinedOffset ba979db26c Rollback of change to hide checkbox if there are less than 2 rows, this seems to be breaking in some cases 2012-07-18 17:16:56 -03:00
UndefinedOffset 4e77810771 Changed minimum number of items to be 2, since having the toggle there for 1 doesn't make any sense 2012-07-18 10:39:37 -03:00
UndefinedOffset 38c6515d64 Toggle is now hidden if there are no items in the grid much like GridFieldPaginator 2012-07-18 10:13:17 -03:00
UndefinedOffset b1c3e09ca6 Fixed issue where the sort order could become confused because the filter() was not applied when calling fixSortColumn() 2012-07-10 11:33:22 -03:00
Ed bf52ce15d2 Fixed error caused by the limit not clearing when an attempt is made to get the max sort index 2012-06-18 20:32:51 -03:00
Ed 5f4a217630 MINOR: Added label to the "Allow Drag and Drop" text so that clicking this will activate the checkbox
MINOR: Fixed line-height issues added in beta 3
2012-05-31 19:50:33 -03:00
Ed ed00b22574 Fixed undefined variable $gridField which would cascade into a fatal error when correcting sort indexes of 0 on many_many relationships 2012-05-18 21:04:34 -03:00
UndefinedOffset b0fcb318ad Added visual cue when moving cross pages
Implemented a better sorting algorithm for sorting cross pages

Removed sorting to first page and last page as this would mean re-indexing allot of items potentially
2012-05-18 10:50:09 -03:00
Ed ade87d5ff1 Fixed sorting of items with a sort order of 0 by giving them a sort index which puts them at the end 2012-05-17 22:05:56 -03:00
UndefinedOffset a768c27133 Fixed issue where the datalist would get modified and cause issues with the returned display 2012-05-17 17:04:53 -03:00
UndefinedOffset 786af43ca9 Fixed issue where sortable header and filter could potentially get put back in when changing pages
Fixed issue when sorting cross pages with a many_many list
2012-05-17 16:43:29 -03:00