tonyair/sortablegridfield
1
0
Fork 0
mirror of https://github.com/UndefinedOffset/SortableGridField.git synced 2024-10-22 15:05:38 +00:00
Code Issues Projects Releases Wiki Activity

Fixed undefined variable $gridField which would cascade into a fatal error when correcting sort indexes of 0 on many_many relationships

Browse Source
This commit is contained in:
Ed 2012-05-18 21:04:34 -03:00
parent 09326e0c7a
commit ed00b22574
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
code/forms/GridFieldSortableRows.php
View File

@ -102,7 +102,7 @@ class GridFieldSortableRows implements GridField_HTMLProvider, GridField_ActionP
//Detect and correct items with a sort column value of 0 (push to bottom) //Detect and correct items with a sort column value of 0 (push to bottom)
$this->fixSortColumn($dataList); $this->fixSortColumn($gridField, $dataList);
return $dataList->sort($this->sortColumn); return $dataList->sort($this->sortColumn);
@ -110,9 +110,10 @@ class GridFieldSortableRows implements GridField_HTMLProvider, GridField_ActionP
/** /**
* Detects and corrects items with a sort column value of 0, by appending them to the bottom of the list * Detects and corrects items with a sort column value of 0, by appending them to the bottom of the list
* @param GridField $gridField Grid Field Reference
* @param SS_List $dataList Data List of items to be checked * @param SS_List $dataList Data List of items to be checked
*/ */
protected function fixSortColumn(SS_List $dataList) { protected function fixSortColumn($gridField, SS_List $dataList) {
$list=clone $dataList; $list=clone $dataList;
$list->limit(0); $list->limit(0);
$max = $list->Max($this->sortColumn); $max = $list->Max($this->sortColumn);