From 8b10f39dce093d7a920e674e08d513aa75d73cbd Mon Sep 17 00:00:00 2001 From: Ed Date: Wed, 10 Jul 2013 14:20:16 -0300 Subject: [PATCH] Fixed issue with 3.1 caused by DataList being full immutable issue #33 --- code/forms/GridFieldSortableRows.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/code/forms/GridFieldSortableRows.php b/code/forms/GridFieldSortableRows.php index 51d8785..0ee764d 100644 --- a/code/forms/GridFieldSortableRows.php +++ b/code/forms/GridFieldSortableRows.php @@ -394,13 +394,15 @@ class GridFieldSortableRows implements GridField_HTMLProvider, GridField_ActionP if ($data['Target'] == 'previouspage') { - $sortPositions = $items->limit($paginator->getItemsPerPage() + 1, ($paginator->getItemsPerPage() * ($currentPage - 1)) - 1)->column($sortColumn); + $items = $items->limit($paginator->getItemsPerPage() + 1, ($paginator->getItemsPerPage() * ($currentPage - 1)) - 1); } else if ($data['Target'] == 'nextpage') { - $sortPositions = $items->limit($paginator->getItemsPerPage() + 1, $paginator->getItemsPerPage() * ($currentPage - 1))->column($sortColumn); + $items = $items->limit($paginator->getItemsPerPage() + 1, $paginator->getItemsPerPage() * ($currentPage - 1)); } else { user_error('Not implemented: '.$data['Target'], E_USER_ERROR); } + $sortPositions = $items->column($sortColumn); + //Start transaction if supported if(DB::getConn()->supportsTransactions()) {