diff --git a/app/src/Extensions/ElementRows.php b/app/src/Extensions/ElementRows.php index ceeb5e3..55f1657 100644 --- a/app/src/Extensions/ElementRows.php +++ b/app/src/Extensions/ElementRows.php @@ -102,22 +102,27 @@ class ElementRows extends DataExtension } // move parent elements - if($this->isList()){ - $tab->push(DropdownField::create( - 'MoveElementIDToParent', - 'Move an element from the list to parent', - $this->owner->getField('Elements')->Elements()->map('ID', 'Title') - )->setEmptyString('(select an element to move)')); + if ($this->isList()) { + $currEls = $this->owner->getField('Elements')->Elements(); + if ($currEls->count()) { + $tab->push(DropdownField::create( + 'MoveElementIDToParent', + 'Move an element from the current list to parent', + $currEls->map('ID', 'Title') + )->setEmptyString('(select an element to move)')); + } - $tab->push(DropdownField::create( - 'MoveElementIDFromParent', - 'Move an element from parent to the list', - $this->owner->Parent()->Elements() - ->exclude('ID', $this->owner->ID) - ->map('ID', 'Title') - )->setEmptyString('(select an element to move)')); + $parentEls = $this->owner->Parent()->Elements()->exclude('ID', $this->owner->ID); + if ($parentEls->count()) { + $tab->push(DropdownField::create( + 'MoveElementIDFromParent', + 'Move an element from the parent to the current list', + $parentEls->map('ID', 'Title') + )->setEmptyString('(select an element to move)')); + } } + $fields->findOrMakeTab('Root.Settings') ->push(LiteralField::create( 'ClassName', @@ -269,9 +274,10 @@ class ElementRows extends DataExtension return $type; } - public static function MoveElement($moveID, $targetID) { + public static function MoveElement($moveID, $targetID) + { $el = BaseElement::get_by_id($moveID); - if(!$el) { + if (!$el) { return false; } @@ -288,14 +294,14 @@ class ElementRows extends DataExtension $moveID = $this->owner->getField('MoveElementIDFromParent'); $targetID = $moveID ? $this->owner->Elements()->ID : null; - if($moveID && $targetID) { + if ($moveID && $targetID) { self::MoveElement($moveID, $targetID); } $moveID = $this->owner->getField('MoveElementIDToParent'); $targetID = $moveID ? $this->owner->Parent()->ID : null; - if($moveID && $targetID) { + if ($moveID && $targetID) { self::MoveElement($moveID, $targetID); } } diff --git a/app/src/Tests/TestServer.php b/app/src/Tests/TestServer.php index 3c13577..db1bb7b 100644 --- a/app/src/Tests/TestServer.php +++ b/app/src/Tests/TestServer.php @@ -13,6 +13,7 @@ use SilverStripe\Core\Cache\FilesystemCacheFactory; use SilverStripe\Core\Config\Config; use SilverStripe\Core\Convert; use SilverStripe\Dev\BuildTask; +use SilverStripe\Dev\Deprecation; use SilverStripe\Assets\File; class TestServer extends BuildTask @@ -24,6 +25,28 @@ class TestServer extends BuildTask { echo ''; + echo '
File | Size limit |
---|