From 527b2e4f457117c8fbd958d07ca0f3339c5ef5d6 Mon Sep 17 00:00:00 2001 From: spekulatius Date: Wed, 17 Dec 2014 12:34:25 +1300 Subject: [PATCH 1/2] Update VersionFeed_Controller.php Fixes reported error #11 --- code/VersionFeed_Controller.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/code/VersionFeed_Controller.php b/code/VersionFeed_Controller.php index 68e0768..9280f1f 100644 --- a/code/VersionFeed_Controller.php +++ b/code/VersionFeed_Controller.php @@ -48,7 +48,10 @@ class VersionFeed_Controller extends Extension { */ public function changes() { // Check viewability of changes - if(!Config::inst()->get('VersionFeed', 'changes_enabled') || !$this->owner->PublicHistory) { + if(!Config::inst()->get('VersionFeed', 'changes_enabled') + || !$this->owner->PublicHistory + || $this->owner->ID == -1 + ) { return $this->owner->httpError(404, 'Page history not viewable'); } From 108f618d62893f419d0b8f6449f898a798f2b750 Mon Sep 17 00:00:00 2001 From: spekulatius Date: Wed, 17 Dec 2014 14:22:51 +1300 Subject: [PATCH 2/2] Update VersionFeed_Controller.php Make it compatible with the existing test --- code/VersionFeed_Controller.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/VersionFeed_Controller.php b/code/VersionFeed_Controller.php index 9280f1f..bde0fa9 100644 --- a/code/VersionFeed_Controller.php +++ b/code/VersionFeed_Controller.php @@ -50,7 +50,7 @@ class VersionFeed_Controller extends Extension { // Check viewability of changes if(!Config::inst()->get('VersionFeed', 'changes_enabled') || !$this->owner->PublicHistory - || $this->owner->ID == -1 + || $this->owner->Version == -1 ) { return $this->owner->httpError(404, 'Page history not viewable'); }