tonyair
/
silverstripe-versionfeed
mirror of https://github.com/silverstripe/silverstripe-versionfeed
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #92 from creative-commoners/pulls/3.1/remove-todo 

MNT Remove TODO comments
This commit is contained in:
Guy Sartorelli 2023-10-20 10:38:38 +13:00 committed by GitHub
parent 9b688adbef 58e03f8ab2
commit c19d901123
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/VersionFeed.php
View File

@ -203,7 +203,6 @@ class VersionFeed extends SiteTreeExtension
public function getSiteRSSLink()
{
// TODO: This link should be from the homepage, not this page.
if (Config::inst()->get(get_class(), 'allchanges_enabled')
&& SiteConfig::current_site_config()->AllChangesEnabled
) {

4
tests/VersionFeedFunctionalTest.php
View File

@ -175,7 +175,7 @@ class VersionFeedFunctionalTest extends FunctionalTest
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version
$this->assertContains('Changed: Page1', $titles);
$this->assertNotContains('Changed: Page2', $titles);
@ -184,7 +184,7 @@ class VersionFeedFunctionalTest extends FunctionalTest
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version
$this->assertNotContains('Changed: Page1', $titles);
$this->assertContains('Changed: Page2', $titles);
}