tonyair/silverstripe-versionfeed
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-versionfeed synced 2024-10-22 11:05:31 +02:00
Code Issues Projects Releases Wiki Activity

MNT Remove TODO comments

Browse Source
This commit is contained in:
Sabina Talipova 2023-10-10 14:46:19 +13:00
parent 9b688adbef
commit 58e03f8ab2
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/VersionFeed.php
View File

@ -203,7 +203,6 @@ class VersionFeed extends SiteTreeExtension
public function getSiteRSSLink() public function getSiteRSSLink()
{ {
// TODO: This link should be from the homepage, not this page.
if (Config::inst()->get(get_class(), 'allchanges_enabled') if (Config::inst()->get(get_class(), 'allchanges_enabled')
&& SiteConfig::current_site_config()->AllChangesEnabled && SiteConfig::current_site_config()->AllChangesEnabled
) { ) {

4
tests/VersionFeedFunctionalTest.php
View File

@ -175,7 +175,7 @@ class VersionFeedFunctionalTest extends FunctionalTest
$titles = array_map(function ($item) { $titles = array_map(function ($item) {
return (string)$item->title; return (string)$item->title;
}, $xml->xpath('//item') ?? []); }, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version
$this->assertContains('Changed: Page1', $titles); $this->assertContains('Changed: Page1', $titles);
$this->assertNotContains('Changed: Page2', $titles); $this->assertNotContains('Changed: Page2', $titles);
@ -184,7 +184,7 @@ class VersionFeedFunctionalTest extends FunctionalTest
$titles = array_map(function ($item) { $titles = array_map(function ($item) {
return (string)$item->title; return (string)$item->title;
}, $xml->xpath('//item') ?? []); }, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version
$this->assertNotContains('Changed: Page1', $titles); $this->assertNotContains('Changed: Page1', $titles);
$this->assertContains('Changed: Page2', $titles); $this->assertContains('Changed: Page2', $titles);
} }