Merge 422bc0256a into 4f821d1188

Merge pull request #1336 from creative-commoners/pulls/7/field-validators
MNT Fix unit test
2024-10-22 17:05:42 +02:00 · 2024-10-15 21:45:02 +13:00 · 2024-10-15 15:10:40 +13:00 · 2024-10-15 11:03:34 +13:00
1 changed files with 34 additions and 9 deletions
--- a/tests/php/Control/UserDefinedFormControllerTest.php
+++ b/tests/php/Control/UserDefinedFormControllerTest.php
@ -584,16 +584,41 @@ class UserDefinedFormControllerTest extends FunctionalTest
    public static function provideValidEmailsToArray()
    {
        return [
-            [[], [null]],
-            [[], [' , , ']],
-            [[], ['broken.email, broken@.email, broken2.@email']],
            [
-                ['broken@email', 'correctemail@email.com'],
-                [', broken@email, email@-email.com,correctemail@email.com,']
+                'input' => [
+                    null
+                ],
+                'expected' => [],
            ],
            [
-                ['correctemail1@email.com', 'correctemail2@email.com', 'correctemail3@email.com'],
-                ['correctemail1@email.com, correctemail2@email.com, correctemail3@email.com']
+                'input' => [
+                    ' , , '
+                ],
+                'expected' => [],
+            ],
+            [
+                'input' => [
+                    'broken.email, broken@.email, broken2.@email'
+                ],
+                'expected' => [],
+            ],
+            [
+                'input' => [
+                    ', broken@email, email@-email.com,correctemail@email.com,'
+                ],
+                'expected' => [
+                    'correctemail@email.com'
+                ],
+            ],
+            [
+                'input' => [
+                    'correctemail1@email.com, correctemail2@email.com, correctemail3@email.com'
+                ],
+                'expected' => [
+                    'correctemail1@email.com',
+                    'correctemail2@email.com',
+                    'correctemail3@email.com'
+                ],
            ]
        ];
    }
@ -602,7 +627,7 @@ class UserDefinedFormControllerTest extends FunctionalTest
     * Test that provided email is valid
     */
    #[DataProvider('provideValidEmailsToArray')]
-    public function testValidEmailsToArray(array $expectedOutput, array $input)
+    public function testValidEmailsToArray(array $input, array $expected)
    {
        $class = new ReflectionClass(UserDefinedFormController::class);
        $method = $class->getMethod('validEmailsToArray');
@ -610,6 +635,6 @@ class UserDefinedFormControllerTest extends FunctionalTest

        $controller = new UserDefinedFormController();

-        $this->assertEquals($expectedOutput, $method->invokeArgs($controller, $input));
+        $this->assertEquals($expected, $method->invokeArgs($controller, $input));
    }
 }
Author	SHA1	Message	Date
Guy Sartorelli	b59946b87f	Merge `422bc0256a` into `4f821d1188`	2024-10-15 21:45:02 +13:00
Guy Sartorelli	4f821d1188	Merge pull request #1336 from creative-commoners/pulls/7/field-validators MNT Fix unit test	2024-10-15 15:10:40 +13:00
Steve Boyd	6f0b4f0b99	MNT Fix unit test	2024-10-15 11:03:34 +13:00