Commit Graph

300 Commits

Author SHA1 Message Date
Nik Rolls
da6a624b6c - Added calls to Object#extend in EditableFormField's getFieldConfiguration and getFieldValidationOptions
- Added tests for extensions on EditableFormField
2013-12-05 19:08:08 +13:00
Jyrki Lilja
79682e7627 Fix #175. Bring back support checking for radio field values. 2013-12-03 20:10:17 +13:00
Sean Harvey
425881257b BUG Performance improvements of SubmittedFormField queries.
When there are a lot of SubmittedForm records the UserDefinedForm
page takes a long time to load in the CMS, and oftens exceeds
the PHP memory limit well beyond 128M.

Previously UserDefinedForm::getCMSFields() would build a list of
name => value from all SubmittedFormField records, but it would
do this twice, once in getCMSFields() and another time in
UserFormsGridFieldFilterHeader. It would also use the full ORM
to build this list, when all it needs is a map of the Name
and Value columns.

This fixes that to build the columns once in getCMSFields() using
DB::query() and it'll pass those columns along to
UserFormsGridFieldFilterHeader as well so it doesn't do it twice.
2013-11-13 17:08:49 +13:00
Jyrki Lilja
27d4476dec Add support for defining clear button text.
A new translations to be added:

- UserDefinedForm.CLEARBUTTON
- UserDefinedForm.TEXTONCLEAR
2013-11-11 15:32:44 +02:00
Ingo Schommer
323f66ad74 Fixed globalisation for field list 2013-11-06 15:05:31 +01:00
Mike Penhall
a6400dcfd0 Update FieldEditor.php 2013-11-04 16:08:32 +13:00
Mike Penhall
06ad657f6c Escaped addField() query to work with Postgres
I was getting a warning in the CMS with a Postgres database due to the fields on lines 191 - 193 not being double quoted.
2013-11-01 16:08:15 +13:00
Ingo Schommer
aa0f8dbc7b Transifex support, js globalisation 2013-10-30 14:31:51 +01:00
Will Rossiter
f66c3c340a Merge pull request #168 from danieldia/patch-1
FIX: Ensure that the data-add-url single quotes are not processed by join_links
2013-10-17 00:25:12 -07:00
danieldia
bbe1c5fb6a FIX: Ensured that the data-add-url single quotes are not processed by join_links
Due to the fact that the last bracket meant that join_links was actually sent URL + ' (eg; http://myurl.com' ), this caused problems when the quote was getting escaped - and actually prevented users from adding form fields in the CMS, with a 500. This fix ensures the closing quote is not processed by join_links.
2013-10-17 16:05:04 +13:00
Kirk Mayo
99de36afef BUG: Fixes #166 for SQL server which does not like empty strings as numerics 2013-10-17 15:01:41 +13:00
Will Rossiter
099e91807b Merge pull request #160 from hafriedlander/fix/filefield
FIX submitted fieldfields in submission details in CMS
2013-09-04 17:14:06 -07:00
Hamish Friedlander
0c39fad116 FIX submitted fieldfields in submission details in CMS
If you had a EditableFileField in your userform, the submission table in
the CMS would just say "Array" rather than link to the file, making it fairly
useless
2013-09-05 09:46:38 +12:00
Will Rossiter
9b134f1a78 FIX: Check security ID on admin non form links (Fixes #158) 2013-09-04 23:35:01 +12:00
Mellisa Hankins
86992971f8 FEATURE: Add data and form arguments to Filtered Email Recipients
Most use cases for Filtered Email Recipients will probably require
using the data submitted via the user form.
2013-09-04 16:32:24 +10:00
Hamish Friedlander
d887f0e196 FIX EditableCountryDowndownField being broken by removal of Geoip in 3.0 2013-08-29 14:03:09 +12:00
Will Rossiter
55a5187f79 FIX: escape columns and tables for postgres 2013-07-15 21:52:30 +12:00
Will Rossiter
775eb66053 private statics for 3.1 2013-07-15 20:49:49 +12:00
Mateusz Uzdowski
eae3283e4c BUG Update allowed_actions on frontend Controller. 2013-07-09 15:20:19 +12:00
Will Rossiter
3352fe38b0 Merge pull request #132 from Focus-Flow/bug/quotes-in-editableoption-title
BUG: support quotes in EditableOption Title
2013-06-04 02:52:18 -07:00
Will Rossiter
d20ab0dd89 Merge pull request #129 from silverstripe-rebelalliance/hackathon
BUG: Fixes #119 adds a tasks to clean up columns for EditableFormField
2013-06-04 02:51:11 -07:00
Freddy Vulto
4c7d50217f Fix duplication of custom rules. Rules may depend on fields. These internal field IDs in the targets now also get updated to their new names (GitHub: #19). 2013-06-04 21:48:29 +12:00
Jyrki Lilja
896e8591f7 BUG: Use $this->Title correctly. 2013-06-04 09:17:23 +03:00
Jyrki Lilja
0b0834c873 BUG: Fix radio field with " in Title. 2013-06-04 08:20:03 +03:00
Jyrki Lilja
e8aeb692fd BUG: Fix checkbox group with " in option titles. 2013-06-04 08:15:57 +03:00
Will Rossiter
b81e4cb7c9 FIX: update visibility of static 2013-06-02 14:08:10 +12:00
Kirk Mayo
a43988af60 BUG: Fixes #119 adds a tasks to clean up columns for EditableFormField 2013-05-25 16:03:59 +12:00
Sean Harvey
e5f8d13b15 BUG SubmittedForm can't be created by non-ADMIN 2013-05-13 14:32:41 +12:00
Sean Harvey
3f223b691b BUG Normal users (non-ADMIN) can't create any email recipients 2013-05-13 14:31:25 +12:00
Sean Harvey
3de6795aa4 BUG Fixing non-ADMIN permission to view SubmittedForm/SubmittedFormField 2013-05-01 10:49:57 +12:00
Fred Condo
756f15a4ac Restore the EditableCountryDropdownField class
Reverts "MINOR Removed the country dropdown field due to the framework
has removed the CountryDropdownField"

This reverts commit cbe1dce4ff.

Framework has not, in fact, removed CountryDropdownField. This commit
restores the EditableCountryDropdownField class.
2013-04-24 09:57:33 -07:00
ARNHOE
9ac8500b41 Fixed typo, live validation works again 2013-04-22 17:17:40 +03:00
Will Rossiter
a8ca0184c3 FIX: validate required fields even with rules. (Fixes #116) 2013-04-17 19:31:09 +12:00
Damian Mooyman
a0f48d636e BUG Fixed incorrect static member declaration
- Changed configurable static variables to private as per recent API updates to 3.1
- Use of statics as configurable variables replaced with config api usage
2013-04-10 11:35:58 +12:00
Fred Condo
f0f9ea702c BUG: Set the summary fields of UserDefinedForm_EmailRecipient dynamically via config system
You can't dynamically expose statics; that's a no-op in 3.1
2013-04-04 12:14:22 -07:00
Fred Condo
656a9fbb4e BUG: Fix access to static configuration variables
- Make statics private
- Use Config::get rather than eval to read private statics
- Add a helper function to expose UserDefinedForm_EmailRecipient::$summary_fields
  (to make them available for i18n).
2013-04-03 14:31:37 -07:00
Ash Kyd
68bc428fe2 Added check for a blank title in the HTML Block/EditableLiteralField so we don't print empty labels. 2013-04-03 12:35:02 +10:00
Stephen Shkardoon
5c9a962b21 Uncasted user input cause SQL issues 2013-03-24 23:35:23 +13:00
Will Rossiter
b096cf611a FIX: update DropdownField usage for 3.1 2013-03-21 23:22:51 +13:00
Will Rossiter
416a5b8864 FIX: fix submissions grid field in 3.0 versions (#96, #100) 2013-03-16 12:18:51 +13:00
mschilder
caec25101d Update UserDefinedForm.php
Changed two typos: UserDefinedform must be UserDefinedForm
2013-03-15 12:32:07 +01:00
Will Rossiter
75fb471f2c FIX use sqlquery for building sort query 2013-03-05 11:36:39 +13:00
Will Rossiter
c4c547321c NEW Filter submissions by created date 2013-03-05 11:10:23 +13:00
Will Rossiter
8e252c88ed NEW Migrate submissions section to a GridField instance. (Fixes #94) 2013-03-05 10:45:54 +13:00
Will Rossiter
527b63786d FIX Resolve issue with multiple dependent rules
Implementation of the rules required that a dependent field could only rely on one implementation. This patch joins all those dependencies together in one function to exclude. Tests / a rewrite of this behavior is on the horizon.
2013-02-27 16:05:30 +13:00
Will Rossiter
55c455b802 FIX: remove redundant extension definition 2013-02-04 20:15:07 +13:00
Menno Schilder
3015997bdf Added Placeholders.js to enable placeholder functionality in IE9 and below 2013-01-29 22:46:34 +13:00
Menno Schilder
cd9af7e13f Added options to enable live validation and hide field labels 2013-01-29 22:46:34 +13:00
Prem Mariappan
203898bd1a FIX: duplicate replyTo addresses appended 2013-01-29 22:40:28 +13:00
Will Rossiter
6f671d304d FIX: save a null value instead of upload data. (Fixes #87) 2013-01-29 21:44:00 +13:00