Steve Boyd
746ac8aedf
FIX Use HTMLValue::class
2023-01-18 10:34:46 +13:00
Steve Boyd
7a6cd1c211
API Stop using deprecated API
2022-11-29 09:36:08 +13:00
Steve Boyd
2a2b66a09b
API Update deprecations
2022-11-16 11:57:49 +13:00
Loz Calver
c0fd386ea7
Fix incorrect label on unwritten field groups
2022-10-27 10:42:43 +01:00
Dylan Wagstaff
3cd8c7ea77
FIX submission performance issues with large data
...
The more submissions a form receives, the more submission fields it must
process just to be able to load `getCMSFields`. Arguably submission data
does not belong here, but this is beyond the scope of this patch.
On popular forms it is not improbable to be trying to process 300,000
submitted fields just to test the unique sets of name and title...
however databases have the ability to do this without wasting PHP cycles
and memory, leaving us with a much smaller set to process and hopefully
bypassing one (of several) performance issues with this module.
The consequence of not making allowance for this is that a page in the
CMS suddenly stops saving or loading via web server or PHP (or both)
process timeouts (e.g. saving takes longer than 30 seconds so saving
never happens).
2022-10-23 23:53:46 +13:00
Sabina Talipova
2750bc3a07
ENH Protect access to the uploaded file without permission
2022-08-31 11:04:15 +12:00
Guy Sartorelli
853fb646dc
Merge branch '5.13' into 5
2022-06-02 10:43:54 +12:00
Guy Sartorelli
5e226f00dd
Merge branch '5.12' into 5.13
2022-06-02 10:43:42 +12:00
Sabina Talipova
63c6326a63
FIX MAX_FILE_SIZE of the last EditableFileField
2022-06-01 14:08:00 +12:00
Sabina Talipova
92aded3016
Protect uploads if folder for EditableFileField was removed
2022-05-25 14:07:35 +12:00
Steve Boyd
792d61fded
ENH PHP 8.1 compatibility
2022-04-13 13:52:56 +12:00
Florian Thoma
33e9a25688
ENH Add config to hide invisible fields from email output
2022-03-15 11:46:18 +11:00
Guy Sartorelli
60cd3d0937
FIX Ensure all fields are available for updateCMSFields(). ( #1089 )
2022-03-03 16:47:45 +13:00
Steve Boyd
9d5b8c1b8e
Merge pull request #1111 from alex-dna/fix/controller-name
...
API Use controller_name static config
2021-10-19 10:47:46 +13:00
Alexandre
9f7e55b346
Use controller_name static config instead of method for better inheritance
2021-09-17 08:23:39 +12:00
Maxime Rainville
1637a29cb4
Merge branch '5.9' into 5
2021-08-26 17:00:48 +12:00
UndefinedOffset
63a1d1deb2
BUGFIX: Fixed issue causing the regex on windows to throw an error due to escaping of the parenthesis caused by DIRECTORY_SEPARATOR
2021-07-19 11:36:03 -03:00
GuySartorelli
02c15f321a
Fix: Allow removing the Versioned extension from EditableFormField
...
fixes #1082
2021-06-21 09:58:35 +12:00
Maxime Rainville
ab20f881eb
Merge branch '5.9' into 5
2021-06-01 14:51:34 +12:00
Steve Boyd
b13cb73deb
FIX Add namespaces back to translation files, use EditibleFileField class
2021-05-31 12:54:31 +12:00
Daniel Hensby
41fa8f0718
Merge pull request #1051 from wilr/wilr-patch-1
...
FIX Uploaded files not appearing in emails and cleanup deleted files.
2021-05-17 09:10:31 +01:00
Will Rossiter
beaf901208
FIX When deleting form submission, delete linked file
2021-05-17 09:13:19 +12:00
Andre Kiste
6b94f9b791
Merge pull request #1040 from creative-commoners/pulls/5.8/email-preview
...
FIX Show correct fields in email preview
2021-05-03 15:25:18 +12:00
Will Rossiter
e925aa1979
FIX Uploaded files not appearing in emails
...
As files uploaded into `DRAFT` mode ensure that these are still displayed in the submitted form.
2021-03-22 21:30:14 +13:00
Chris Penny
72a213790e
MNT Update docblocks and import statements ( #1044 )
2021-02-26 16:13:23 +13:00
Michal Kleiner
0abda42179
Use correct directory separator on Windows when selecting email templates
2021-02-10 11:52:15 +13:00
Steve Boyd
8801790b66
FIX Show correct fields in email preview
...
Co-authored-by: Michael Caruana <mikeyc7m@users.noreply.github.com>
2021-01-17 22:55:10 +13:00
Steve Boyd
ce2fe31bdd
Merge branch '5.7' into 5.8
2021-01-17 15:58:55 +13:00
Dylan Wagstaff
c0a30f1b6a
FIX unrequire fields when they become dataless ( #1016 )
...
* FIX unrequire fields when they become dataless
When fields that collect input data are changed in configuration via the
CMS to become fields that no longer collect input data (e.g. TextField
-> HTML Block), submitting the resulting form results in a fatal error,
server 500 response, etc. due to trying to check if a field without data
(ever) has data in it.
To circumvent this we can set the required state to false if the field
is being converted to one that does not collect data (which FormField
API conveniently provides a check for).
* Move parent::onBeforeWrite() to top of function
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:55:47 +13:00
Michal Kleiner
66bbe44972
FIX Add missing dots in translation string references
2020-12-02 10:01:50 +13:00
Steve Boyd
f81360e737
Merge branch '5.7' into 5
2020-11-12 15:18:00 +13:00
Steve Boyd
ead1827aa1
Merge branch '5.6' into 5.7
2020-11-12 15:17:31 +13:00
Steve Boyd
2a47b1821e
NEW Extension to link file submissions to userform on the used on table
2020-11-04 11:47:50 +13:00
Dylan Wagstaff
0ce94b75f5
FIX correctly calculate MaxFileSizeMB
...
The inputted value is intended to represent megabytes, but is only
multiplied by 1024 - meaning it'd represent kilobytes. This is then used
to compare with the PHP setting number, which is bytes in the range of
megabytes. Kilobytes are always under megabytes, meaning size
comparisons elsewhere in the code are always true.
We should ensure the calculation for validation is correct.
2020-11-01 11:31:23 +13:00
Maxime Rainville
d2bf27c847
MNT Fix broken merged up ( #1013 )
2020-10-22 15:47:17 +13:00
Maxime Rainville
4eb0fe25b9
Merge branch '5.5' into 5.6
2020-10-22 10:22:19 +13:00
Steve Boyd
81fcd669a2
FIX Show custom validation message for checkbox and radio groups
2020-07-21 17:30:55 +12:00
Steve Boyd
46c6d93d9c
Merge branch '5.6' into 5
2020-07-17 23:24:37 +12:00
Steve Boyd
59cd87d842
FIX Trim recipient email addresses before write
2020-07-14 16:41:36 +12:00
Maxime Rainville
27228d12af
[CVE-2020-9309] Require MimeUploadValidator on userformis' File Upload field
2020-07-13 11:33:46 +12:00
3Dgoo
6ca8ce2596
FIX Fixing plain email blank file field value ( #940 )
...
* Fixing plain email blank file field value
2020-07-01 09:00:31 +12:00
Maxime Rainville
25978d3c58
Clean up tests
2020-06-12 00:55:12 +12:00
Andre Kiste
3b40be3b8f
NEW Add folder confirmation modal when adding a new EditableFileField to a userform. ( #972 )
2020-06-10 16:59:01 +12:00
Garion Herman
14ce51e517
NEW Improve Unrestricted Folder warning, bump core requirement to ^4.6 ( #965 )
2020-06-09 21:01:09 +12:00
Maxime Rainville
e2c05d5a55
Minor linting adjustment.
2020-01-14 12:28:04 +13:00
Maxime Rainville
d280c54860
Patch and reorganise some test
2020-01-13 12:15:34 +13:00
Maxime Rainville
793f437289
API Mark EditableFormField::EffectiveDisplayRules() for deprecation
2020-01-13 12:12:14 +13:00
Maxime Rainville
a0cedaeb38
Move conditionalFieldEnabled to EditableFormField as isDisplayed
2020-01-10 17:36:04 +13:00
Jess Champion
25bfc9eaf5
Required fields can have display rules. Hidden required fields are dynamically excluded from server and client side validation.
2020-01-10 10:41:59 +13:00
Charlie Bergthaler
dfeb922818
FIX Add missing import statement for SilverStripe\ORM\ValidationResult in UserDefinedFormController and EditableFileField.
2019-10-07 21:56:22 +13:00
