Commit Graph

297 Commits

Author SHA1 Message Date
Ruud Arentsen
75c6d40fa4 BUG Fix the 'always modified' label in treeview. Fixes #48.
userforms always reported 'modified' in the sitetree. Fixed the issue by
checking the userdefinedform record and the formfields.
2012-10-18 20:19:33 +13:00
Will Rossiter
0aa9572f2c FIX redirect user to form on validation error. (Fixes #62) 2012-10-14 11:45:47 +13:00
Sean Harvey
1cba24880b Fixing deprecated call to Director::redirectBack() 2012-10-11 15:18:51 +13:00
Roman
019f782d2e Added "canView" permission to EmailRecipient. Fixes an issue with non-admin rights in SS3 2012-09-24 19:02:33 +02:00
Will Rossiter
7cc7bb4ce6 Add description to page type 2012-09-11 21:32:48 +12:00
Will Rossiter
ee8ca5caf1 NEW: allow setting of custom reply to address rather than from address. (Fixes #28) 2012-09-11 21:32:47 +12:00
Will Rossiter
e0a476ea15 FIX: make email recipients dropdowns unselectable in 3.0 API 2012-09-11 21:32:47 +12:00
Will Rossiter
90ba5031ab Merge pull request #51 from mateusz/report-visibility-master
ADD Add report visibility setting to EditableFormHeading
2012-09-11 00:27:40 -07:00
Mateusz Uzdowski
eb1b9b62cd BUG Fix the date field conditional to work with dropdown.
In this case they keyup will not be triggered at all.
2012-09-11 18:56:29 +12:00
Mateusz Uzdowski
1fa4c2d81d BUG Fix the edge cases for radio button conditionals.
The specific situation this is fixing is that when server-side
validation fails and results in form having non-default values. In this
case the visibility might not be correct and will need to be updated.

Also, we cannot rely on onclick events on radio group to find out the
current value when we are loading - instead we need to actually find
out the currently selected radio button.

Fixes the IsBlank and IsNotBlank conditions as well.
2012-09-11 18:56:29 +12:00
Mateusz Uzdowski
bcd9083d1c BUGFIX: prevent form from expiring on users - ping regularly.
The form throws a CSRF error if left for too long by itself. This is
especially important for long forms.

Use local ping function, as the CMS ping returns 403 when BasicAuth is
enabled.
2012-09-11 10:12:15 +12:00
Mateusz Uzdowski
d1b6ec224d ADD Add report visibility setting to EditableFormHeading
Same as already existing setting on EditableLiteralField.
2012-09-10 16:07:52 +12:00
Naomi Guyer
104a584ebf BUG: Too many tabs
Combined a few tabs so that the interface is a little less cluttered
when adding this module. When this is
fixed:http://open.silverstripe.org/ticket/7268 it is recommended that
user forms add it's own parent tab to the ui to group user forms tabs
together.
2012-08-13 11:29:42 +12:00
Kirk Mayo
e4875edd05 BUG: Coding convention changes mainly replacing spaces with tabs 2012-07-17 16:09:31 +12:00
Kirk Mayo
eba5edd60b BUG: open ticket 7314 fixing some bugs that have been found 2012-07-17 15:58:24 +12:00
Paul Meyrick
077ce6c645 MINOR: Use setRows() and instead of constructor arguments 2012-06-08 16:18:36 +12:00
Mateusz Uzdowski
2b26d544f9 BUGFIX: Director::redirect is deprecated, use Controller. 2012-06-05 15:08:09 +12:00
Stig Lindqvist
1590172d0c BUGFIX: A Submitted file couldn't not be shown / downloaded in the submission report 2012-05-14 14:16:46 +12:00
Stig Lindqvist
0bbfb720ca BUGFIX: Submissions could not be paginated. 2012-05-14 14:16:07 +12:00
Stig Lindqvist
20e3f3c8cd BUGFIX: The EditableFileField crashed when user uploads a not allowed filetype 2012-05-14 10:20:19 +12:00
Stig Lindqvist
ee3de104ec BUGFIX: EditableDateFields nice calendar does not popup in the frontend 2012-05-14 10:20:19 +12:00
Stig Lindqvist
46c0efc9ae BUGFIX: MemberListField called non existing methods on Framework classes 2012-05-14 10:20:19 +12:00
Stig Lindqvist
cbe1dce4ff MINOR Removed the country dropdown field due to the framework has removed the CountryDropdownField
This
2012-05-14 10:20:18 +12:00
Stig Lindqvist
8e80dc2040 MINOR Style guidelines 2012-05-09 15:17:06 +12:00
Will Rossiter
3256663cad BUGFIX: fixes for 3.0 unit tests. Ensure form is not shown if no fields in the list, Prevent nested with getSubmissions(). 2012-05-07 22:00:18 +12:00
Will Rossiter
52f68059d9 ENHANCEMENT: show link to file download in CSV export. Fixes #32 2012-05-07 21:19:16 +12:00
Will Rossiter
2e66d41c56 Merge branch '3.0-compatibility' of github.com:stojg/silverstripe-userforms into pull-33
Conflicts:
	code/model/UserDefinedForm.php
2012-05-07 19:34:38 +12:00
Will Rossiter
ca12d54173 Merge remote-tracking branch 'origin/master' 2012-05-07 18:12:41 +12:00
Will Rossiter
6c1b843fac BUGFIX: fix regression with literal fields not showing content 2012-05-07 18:10:57 +12:00
Stig Lindqvist
63469ced2f MINOR Some code cleanup 2012-05-07 17:41:30 +12:00
Stig Lindqvist
d9ff70595f MINOR Setting the url where the javascript should call by ajax to add a field to the user defined form 2012-05-07 17:41:30 +12:00
Stig Lindqvist
368211c7e5 MINOR addfield and addoptionfield methods are now in $allowed_actions 2012-05-07 17:41:30 +12:00
Stig Lindqvist
2d91f2f456 Minor Setting rows and cols on TextField the non deprecated way 2012-05-07 17:41:30 +12:00
Stig Lindqvist
4e2854bb08 MINOR Must follow parents signature 2012-05-07 17:41:29 +12:00
Stig Lindqvist
958d49556d MINOR Overriding methods must have the same signature declaration as the parent class due to E_STRICT. 2012-05-07 17:41:29 +12:00
Stig Lindqvist
816edabd3f MINOR Added public keyword for methods (style guidelines) 2012-05-07 17:41:29 +12:00
edchipman@gmail.com
c036af79ab MINOR: Added a few extension points to allow tapping into various areas 2012-05-07 17:41:29 +12:00
edchipman@gmail.com
ef3953fc68 Replaced instances of new DataObjectSet() with new ArrayList()
Removed Validator::set_javascript_validation_handler() call
2012-05-07 17:41:29 +12:00
edchipman@gmail.com
5de26cd897 Replaced all instances of new FieldSet() with new FieldList()
Replaced the complex table field used for editing the email recipients with GridField

Replaced instances of SAPPHIRE_DIR with FRAMEWORK_DIR

Replaced instances of sapphire/ in css and templates with framework/

Re-organized tabs on user defined form so they are top level

Replaced calls to toDropdownMap() with map()

Renamed getCMSFields_forPopup() top getCMSFields()
2012-05-07 17:41:29 +12:00
guywatson
94b491e125 Incorrect Logic 2012-04-20 10:12:03 +10:00
Will Rossiter
aa67b9da2f FEATURE: allow users to enter extra classes on form fields via the cms. PATCH via TotalNet. Fixes: #5791 2012-04-14 23:03:43 +12:00
Will Rossiter
965d8d00b0 BUGFIX: fix error location for radio fields. Fixes #5635 and #6846. 2012-04-14 22:43:02 +12:00
Will Rossiter
bb1c4d8043 Merge branch 'master' of github.com:silverstripe/silverstripe-userforms 2012-04-14 22:01:23 +12:00
Will Rossiter
0978a1ebf8 BUGFIX: avoid validating fields which have the potential to be hidden. Fixes #5406 and #3 2012-04-14 22:00:13 +12:00
Will Rossiter
2c9e68a928 MINOR: clean up of project. MINOR: removed versioned task. Out of date for usage. 2012-04-14 21:59:56 +12:00
Will Rossiter
7cd37cf0a3 Merge pull request #7 from marcokernler/url-params
FEATURE: Allow pre filled form fields via url params
2012-04-13 18:01:01 -07:00
Tim Klein
c72d7f09fb using CountryDropDownField instead of DropdownField to make use of the extra functionality provided through CountryDropdownField, such as defautling to visitor country 2012-03-23 09:41:19 +13:00
marcokernler
ab7e53fb6f MINOR - Added escaping for values passed by url params 2011-12-20 22:17:23 +01:00
marcokernler
e24e9b4245 MINOR - Now follows the coding conventions 2011-12-20 22:15:49 +01:00
marcokernler
c575c8d981 MINOR - Allow pre filled form fields via url params 2011-12-19 16:47:22 +01:00
Will Rossiter
350a6fa65d Merge pull request #6 from mattclegg/master
BUGFIX: fixed non javascript validation. MINOR: Tidied-up formatting.
2011-12-05 15:33:59 -08:00
Will Rossiter
2ea28495f7 BUGFIX: fix titles and labels being escaped multiple times resulting in html entities displaying in submission pages, export and emails. Fixes http://open.silverstripe.org/ticket/6787 2011-12-05 23:19:20 +13:00
Will Rossiter
a81a164bcf FEATURE: allow EditableLiteralFields to be hidden from report extracts. Fixes http://open.silverstripe.org/ticket/6704 2011-12-05 21:38:10 +13:00
Will Rossiter
7148d3e91f MINOR: use title case for EditableTextField. Fixes http://open.silverstripe.org/ticket/5799 2011-12-05 21:18:56 +13:00
swaiba
cbcd6c9eff ensure correct mime type of attached file - this was failing because Mimesweeper not liking the "Content-Type" and they see the following warning:
Bad Data
Recognize SMTP messages
The Content-Type header is invalid - Word document; name="SOMEDOCUEMNT.doc"
2011-11-25 16:48:42 +00:00
Will Rossiter
9020ce82d0 MINOR: files uploaded from forms should be hidden from the search engine 2011-09-16 11:47:09 +12:00
mattclegg
8f8eab018c MINOR Tidied-up formatting 2011-04-08 18:39:05 +01:00
mattclegg
a7a3dcb945 BUGFIX Added validation (for non javascript submits) 2011-04-08 18:36:01 +01:00
Will Rossiter
fed25ad45b BUGFIX: added exists() check on getFormFields (via Bruce Walter) to prevent fieldless forms. BUGFIX: if built form is empty still strip the $UserDefinedForm token out of the content. 2011-03-21 09:14:45 +13:00
Julian Seidenberg
d080c15a49 BUGFIX: fixed double escaping for titles on output while maintaning escaping of special characters. 2011-03-03 16:08:09 +13:00
Will Rossiter
045a01bf2b BUGFIX: fixed double escaping for titles on output. Thanks dhensby. 2011-02-08 21:30:35 +13:00
Will Rossiter
6350a66dfb BUGFIX: fixed undefined index when submitting a blank form. Fixes #6272 2011-01-18 16:15:57 +13:00
Will Rossiter
ed61c03971 BUGFIX: fixed notice with missing $messages var when no fields are required. PATCH via ajshort 2011-01-04 01:37:47 +00:00
Will Rossiter
fb3fb184e1 BUGFIX: fixed incorrect formatting for jQuery.validate rules. ENHANCEMENT: added getErrorMessage() to ensure consistent error messages. BUGFIX: readded missing custom messages 2010-12-19 01:19:19 +00:00
Will Rossiter
9bb51b6cea ENHANCEMENT: return false if no fields have been added to a UserDefinedForm rather than a blank form 2010-12-19 00:40:53 +00:00
Will Rossiter
1feab6d401 ENHANCEMENT: added EditableCountryDropdownField to allow country selection 2010-12-01 21:59:56 +00:00
Ingo Schommer
591ad48eb9 MINOR Checking for class_exists() before SapphireTest::is_running_tests() to avoid including the whole testing framework, and triggering PHPUnit to run a performance-intensive directory traversal for coverage file blacklists 2010-11-30 04:33:58 +00:00
Carlos Barberis
9b17399cd4 ENHANCEMENT: using sys locale instead user selection 2010-11-15 23:23:11 +00:00
Carlos Barberis
e4f7c419b3 ENHANCEMENT: Added dropdown to choose date format on EditableDateField 2010-11-12 03:28:42 +00:00
Mateusz Uzdowski
eec28bc82e BUGFIX: typo 2010-11-02 20:14:28 +00:00
Mateusz Uzdowski
68be4d51d9 MINOR: remove space between entries - this breaks the import in Open Office and Numbers 2010-10-27 01:50:43 +00:00
Mateusz Uzdowski
078043f189 BUGFIX: encode the csv file by hand, fputcsv is not parsing newlines properly 2010-10-21 23:41:47 +00:00
Mateusz Uzdowski
e7ba58970f BUGFIX: provide default file format, as Windows is unable to detect the mime type, and exit after the file is served so the headers will not get overwritten. 2010-10-13 21:04:22 +00:00
Mateusz Uzdowski
cec87a859e BUGFIX: ORDER BY in nested query does not work under MSSQL, remove 2010-10-08 00:56:52 +00:00
Mateusz Uzdowski
a2e998ab79 BUGFIX: IN clause was not being picked up, failing in MSSQL and not giving proper results on MySQL (OS ticket 6072) 2010-10-08 00:29:18 +00:00
Mateusz Uzdowski
8d3cb472dc BUGFIX: remove reliance on str_getcsv (it's PHP 5.3 only).
ENHANCEMENT: sort the columns according to the most recent form setup (thanks jonomenz for the query)
ENHANCEMENT: test quotes and commas
2010-10-07 23:06:49 +00:00
Mateusz Uzdowski
14ff7759a7 BUGFIX: rewrite the export function to fix the bug that multiplied columns when adding rows, and to use built-in php csv functions. 2010-10-07 21:37:21 +00:00
Jean-Fabien Barrios
abee24ed0c ENHANCEMENT: Don't return a blank url when no file is specified 2010-09-22 02:20:28 +00:00
Mark Stephens
40592031ff BUGFIX: Submissions were exported in implied ID order, which is not guaranteed on all DB engines, esp postgres, so put in explicit order 2010-09-20 03:54:52 +00:00
Will Rossiter
5508a5db90 MINOR: removed debug statement 2010-09-14 01:58:39 +00:00
Will Rossiter
503c5c3ff6 ENHANCEMENT: implemented tests for exporting csv files 2010-09-08 10:35:43 +00:00
Will Rossiter
99d4721c88 MINOR: restored export() functionality 2010-09-08 06:34:52 +00:00
Will Rossiter
7eef5646e5 ENHANCEMENT: added test coverage for populateFromPostData() 2010-09-08 03:20:28 +00:00
Will Rossiter
4ff4aa561f MINOR: added translation for body. MINOR: updated en_US.php lang file 2010-09-07 22:48:46 +00:00
Will Rossiter
bc0d4c7692 ENHANCEMENT: Implemented tests to complete email recipients class. APICHANGE: changed *FieldSettings() to *Setting() 2010-09-07 22:44:43 +00:00
Andreas Piening
8a80dfa592 MINOR: some dbms make a difference between 0 and NULL 2010-09-07 02:24:54 +00:00
Will Rossiter
3c1d81d014 ENHANCEMENT: added test coverage for UserDefinedForm.php and placeholders for other sections. API change: processNewFormFields removed
API change: refactored Form() into getFormFields(), getFormActions(), getRequiredFields()

ENHANCEMENT: added updateForm* extension hooks to allow customization of userforms
BUGFIX: gave custom scripts their own ID to enable it to be blocked.
2010-09-03 05:06:13 +00:00
Will Rossiter
5f4d4e7d28 MINOR: removed unnesscary ShowOnLoad save since this is now a CustomSetting field. #5930 2010-08-13 23:51:26 +00:00
Will Rossiter
a203bcd725 BUGFIX: added default language for the sprintf statement 2010-08-06 05:00:16 +00:00
Carlos Barberis
1d6cde42a8 MINOR: added condition to make sure we have submitted date 2010-07-28 23:15:11 +00:00
Saophalkun Ponlu
af2fa007f2 BUGFIX: Resolve wrong escaped double quote characters
ENHANCEMENT: Get unique columns at database level
2010-07-28 07:55:13 +00:00
Will Rossiter
745b614710 BUGFIX: fixed sortable events not updated when loading new fields. ENHANCEMENT: Added RightTitle support to EditableFormFields. Removed parsePrepopulateValue() as usage is not clear and is broken 2010-07-07 09:17:37 +00:00
Will Rossiter
88fe82da03 MINOR: Removed column show on load default since this is no longer required 2010-06-20 05:13:17 +00:00
Will Rossiter
2c99ca1faa BUGFIX: fixed casting of Content. PATCH via ajshort (#5692). 2010-06-08 02:03:55 +00:00
Will Rossiter
a63089b817 ENHANCEMENT: added default to today checkbox for date fields 2010-05-31 09:43:25 +00:00
Will Rossiter
59fabd005c BUGFIX: duplicate email recipients when duplicating a UDF 2010-05-31 09:01:58 +00:00
Will Rossiter
78fe9947b9 MINOR: included CustomParameter field to prevent errors while upgrading. Since no way to nicely delete columns completely via the ORM it can sit there and be all empty 2010-05-31 08:20:04 +00:00
Will Rossiter
50270211f2 ENHANCEMENT: added jquery picker to editabledatefield for date picker. 2010-05-31 07:57:00 +00:00
Will Rossiter
fd0fe1b01d APICHANGE: added getFormattedValue() for UDF submitted form fields to allow subclasses to overload the stored content. BUGFIX: convert newlines from text submissions to br tags so textarea fields actually come out semi readable 2010-05-16 03:55:03 +00:00
Will Rossiter
3257590dc8 BUGFIX: fixed using UDF with the workflow module which only publishs a page when its been modified and UDF was always returning false to any changes 2010-05-16 03:21:04 +00:00