Commit Graph

206 Commits

Author SHA1 Message Date
Guy Sartorelli d2bad6a39e
MNT Fix behat test that was relying on a bug 2024-02-27 16:38:47 +13:00
Steve Boyd eae7c5dedd MNT Fix behat test 2023-12-06 17:02:03 +13:00
Sabina Talipova 95531e78d0
MNT Fix broken build (#1253) 2023-11-29 15:17:08 +13:00
Sabina Talipova 29dddf217f MNT Update behat tests to support toast messages 2023-11-03 15:39:59 +13:00
Steve Boyd f1510dca9e FIX Renable email link to submitted file 2023-09-06 10:54:20 +12:00
Guy Sartorelli 60717e5c04
FIX Use absolute URL for submitted file links in emails (#1226) 2023-08-08 14:53:14 +12:00
Steve Boyd bf49cab678 FIX Prevent infinite recursion when field display rules are co-dependent 2023-05-31 17:33:35 +12:00
Steve Boyd 7a6cd1c211 API Stop using deprecated API 2022-11-29 09:36:08 +13:00
Dylan Wagstaff 0ff72734dd NEW Maximum email attachment size can be configured
Previously hard coded size of 1MB meant any file larger was excluded
from recipient emails - often confusing for CMS admins configuring an
advanced use case for a userform, expecting to recieve files to begin a
business process external to the website.

The configuration has been made to support PHP 'shorthand byte values'
https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes
in the configuration option. This give flexibility around oddly
specific limits, but can also be used to set as 0, disabling attachments

Tests are updated to set up a known state before testing, as to be able
to accurately assert the results. One should test the class they intend,
not an Injector service of some unknown element.
2022-10-24 20:12:58 +13:00
Sabina Talipova 2444e844f1 ENH Replace ADMIN permissions with less permissions in Behat test 2022-09-15 09:24:03 +12:00
Sabina Talipova 2750bc3a07 ENH Protect access to the uploaded file without permission 2022-08-31 11:04:15 +12:00
Guy Sartorelli 12ccb9636c MNT Explicitly set class for test polymorphic has_one 2022-05-31 15:07:04 +12:00
Guy Sartorelli 1144d1d0ad Merge branch '5.13' into 5 2022-05-27 11:33:10 +12:00
Guy Sartorelli b2ef93838c Merge branch '5.12' into 5.13 2022-05-27 11:32:55 +12:00
Steve Boyd d97bc58f20
Merge pull request #1144 from creative-commoners/pulls/5/upload-protected-folder
Protect uploads if folder for EditableFileField was removed
2022-05-25 17:54:44 +12:00
Sabina Talipova 92aded3016 Protect uploads if folder for EditableFileField was removed 2022-05-25 14:07:35 +12:00
Sabina Talipova 0c066a3cfc FIX Add skipping argument and new behat tests 2022-05-25 13:11:29 +12:00
Steve Boyd d81da1eedf ENH Save modified form data when adding new field 2022-05-23 14:01:31 +12:00
Steve Boyd 792d61fded ENH PHP 8.1 compatibility 2022-04-13 13:52:56 +12:00
Maxime Rainville 94fb446094
Merge pull request #1114 from creative-commoners/pulls/5.10/behat
MNT Add behat tests
2021-11-15 14:56:07 +13:00
Steve Boyd 40bd88e81c API phpunit 9 support 2021-11-02 09:52:58 +13:00
Steve Boyd ec747d3f26 MNT Add behat tests 2021-09-28 15:56:34 +13:00
Maxime Rainville 4d9e78a841 Merge branch '5.9' into 5 2021-05-28 14:36:57 +12:00
Maxime Rainville a989700d52 MNT Fix testOrphanRemovalDoesNotAffectOtherClassesWithTheSameID to start with a First Page Step 2021-05-27 11:45:39 +12:00
Daniel Hensby 41fa8f0718
Merge pull request #1051 from wilr/wilr-patch-1
FIX Uploaded files not appearing in emails and cleanup deleted files.
2021-05-17 09:10:31 +01:00
Will Rossiter beaf901208
FIX When deleting form submission, delete linked file 2021-05-17 09:13:19 +12:00
Dan Hensby ce18179d49
Merge pull request #1049 from hamaka/fix/attachments_respecting_hideformdata 2021-05-14 21:32:09 +01:00
Andre Kiste 6b94f9b791
Merge pull request #1040 from creative-commoners/pulls/5.8/email-preview
FIX Show correct fields in email preview
2021-05-03 15:25:18 +12:00
Steve Boyd d178652cf8 MNT Use behat-extension function for clicking elements 2021-04-15 13:25:47 +12:00
Steve Boyd 6794aa7cd3 MNT Unit test for directory seperator on windows 2021-04-13 22:48:52 +12:00
Steve Boyd 52e678c6e7 FIX Include merge fields in plain text emails 2021-04-13 19:05:29 +12:00
Bauke Zwaan 4a883f1641 fix for testing EmailRecipients 2021-04-12 15:22:45 +02:00
Bauke Zwaan 34883adb12 Add testing 2021-04-06 15:46:37 +02:00
Steve Boyd cdf6264242 MNT Behat test for hidden form steps 2021-03-10 16:06:01 +13:00
Steve Boyd 8801790b66 FIX Show correct fields in email preview
Co-authored-by: Michael Caruana <mikeyc7m@users.noreply.github.com>
2021-01-17 22:55:10 +13:00
Dylan Wagstaff c0a30f1b6a
FIX unrequire fields when they become dataless (#1016)
* FIX unrequire fields when they become dataless

When fields that collect input data are changed in configuration via the
CMS to become fields that no longer collect input data (e.g. TextField
-> HTML Block), submitting the resulting form results in a fatal error,
server 500 response, etc. due to trying to check if a field without data
(ever) has data in it.

To circumvent this we can set the required state to false if the field
is being converted to one that does not collect data (which FormField
API conveniently provides a check for).

* Move parent::onBeforeWrite() to top of function

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:55:47 +13:00
Dylan Wagstaff a42729679b
FIX account for owner class while removing orphans (#1018)
* FIX account for owner class while removing orphans
* Explicitly set $page and $block ID's in test fixture

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:29:33 +13:00
Steve Boyd 81fcd669a2 FIX Show custom validation message for checkbox and radio groups 2020-07-21 17:30:55 +12:00
Steve Boyd 59cd87d842 FIX Trim recipient email addresses before write 2020-07-14 16:41:36 +12:00
Maxime Rainville 25978d3c58 Clean up tests 2020-06-12 00:55:12 +12:00
Andre Kiste 3b40be3b8f
NEW Add folder confirmation modal when adding a new `EditableFileField` to a userform. (#972) 2020-06-10 16:59:01 +12:00
Steve Boyd ed53709631 NEW DB column showing if file is userform upload
- UserFormUpload used by File::isTrackedFormUpload()
2020-05-28 13:14:34 +12:00
Steve Boyd e54a825ea3 Merge branch '5.5' into 5 2020-05-27 13:41:51 +12:00
Steve Boyd c3d990f70f
FIX Create image thumbnails for asset-admin for images uploaded through userforms (#969) 2020-05-27 12:26:14 +12:00
Maxime Rainville 39ee08cff9 Remove bool explicit type definition to please PHP 5.6 2020-01-13 12:25:47 +13:00
Maxime Rainville d280c54860 Patch and reorganise some test 2020-01-13 12:15:34 +13:00
Maxime Rainville 793f437289 API Mark EditableFormField::EffectiveDisplayRules() for deprecation 2020-01-13 12:12:14 +13:00
Maxime Rainville a0cedaeb38 Move conditionalFieldEnabled to EditableFormField as isDisplayed 2020-01-10 17:36:04 +13:00
Jess Champion 25bfc9eaf5 Required fields can have display rules. Hidden required fields are dynamically excluded from server and client side validation. 2020-01-10 10:41:59 +13:00
Robbie Averill 483fbc8499 FIX Preview email link now handles cases where it's loaded in the browser, requested via AJAX and used in a trait or a page context 2019-05-17 15:51:11 +12:00