tonyair/silverstripe-userforms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-userforms.git synced 2024-06-29 07:59:24 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #663 from creative-commoners/pulls/4.5/fix-escaped-dollar-signs

Browse Source 
FIX Escape dollar signs in UserForm contents before inserting them with regex
This commit is contained in:
Will Rossiter 2017-09-26 11:14:31 +13:00 committed by GitHub
commit e9f51173e6
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/model/UserDefinedForm.php
View File

@ -411,7 +411,9 @@ class UserDefinedForm_Controller extends Page_Controller
if ($this->Content && $form = $this->Form()) {
$hasLocation = stristr($this->Content, '$UserDefinedForm');
if ($hasLocation) {
$content = preg_replace('/(<p[^>]*>)?\\$UserDefinedForm(<\\/p>)?/i', $form->forTemplate(), $this->Content);
/** @see Requirements_Backend::escapeReplacement */
$formEscapedForRegex = addcslashes($form->forTemplate(), '\\$');
$content = preg_replace('/(<p[^>]*>)?\\$UserDefinedForm(<\\/p>)?/i', $formEscapedForRegex, $this->Content);
return array(
'Content' => DBField::create_field('HTMLText', $content),
'Form' => ""

2
templates/forms/UserFormsCheckboxSetField.ss
View File

@ -3,7 +3,7 @@
<div class="$Class">
<input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value.ATT"<% if $isChecked %>
checked="checked"<% end_if %><% if $isDisabled %> disabled="disabled"<% end_if %> />
<label for="$ID">$Title</label>
<label for="$ID">$Title.XML</label>
</div>
<% end_loop %>
<% else %>