tonyair/silverstripe-userforms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-userforms.git synced 2024-10-22 15:05:42 +00:00
Code Issues Projects Releases Wiki Activity

BUGFIX: Fixed readonly behaviour and boundary conditions for FieldEditor

Browse Source
This commit is contained in:
Sam Minnee 2009-06-08 06:17:15 +00:00
parent df91c536de
commit b637869b70
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
code/editor/FieldEditor.php
View File

@ -31,13 +31,14 @@ class FieldEditor extends FormField {
}
function performReadonlyTransformation() {
$this->readonly = true;
$fields = $this->Fields();
$clone = clone $this;
$clone->readonly = true;
$fields = $clone->Fields();
if($fields) foreach($fields as $field) {
$field->setReadonly();
}
return $this->customise(array('Fields' => $fields));
return $clone->customise(array('Fields' => $fields));
}
/**
@ -50,23 +51,27 @@ class FieldEditor extends FormField {
Requirements::javascript("jsparty/jquery/ui/ui.core.js");
Requirements::javascript("jsparty/jquery/ui/ui.sortable.js");
Requirements::javascript("userforms/javascript/UserForm.js");
// Don't return any fields unless we actually have the dependent parameters set on the form field
if($this->form && $this->form->getRecord() && $this->name) {
$relationName = $this->name;
$fields = $this->form->getRecord()->$relationName();
$relationName = $this->name;
$fields = $this->form->getRecord()->$relationName();
if($fields) {
foreach($fields as $field) {
if(!$this->canEdit()) {
if(is_a($field, 'FormField')) {
$fields->remove($field);
$fields->push($field->performReadonlyTransformation());
if($fields) {
foreach($fields as $field) {
if(!$this->canEdit()) {
if(is_a($field, 'FormField')) {
$fields->remove($field);
$fields->push($field->performReadonlyTransformation());
}
}
$field->setEditor($this);
}
$field->setEditor($this);
}
return $fields;
}
return $fields;
}
/**