From 1643b1a689451902a522e38dea0a3103c4c8aaa6 Mon Sep 17 00:00:00 2001
From: Robbie Averill <robbie@silverstripe.com>
Date: Wed, 1 Nov 2017 11:43:53 +1300
Subject: [PATCH] FIX Explicitly get the Fields() method from controller's data
 record

---
 code/Control/UserDefinedFormController.php | 6 +++---
 code/Form/UserForm.php                     | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/code/Control/UserDefinedFormController.php b/code/Control/UserDefinedFormController.php
index bf7030c..9a0e1fd 100644
--- a/code/Control/UserDefinedFormController.php
+++ b/code/Control/UserDefinedFormController.php
@@ -166,9 +166,9 @@ class UserDefinedFormController extends PageController
 
         $watch = [];
 
-        if ($this->Fields()) {
+        if ($this->data()->Fields()) {
             /** @var EditableFormField $field */
-            foreach ($this->Fields() as $field) {
+            foreach ($this->data()->Fields() as $field) {
                 if ($result = $field->formatDisplayRules()) {
                     $watch[] = $result;
                 }
@@ -216,7 +216,7 @@ JS
         $attachments = array();
         $submittedFields = ArrayList::create();
 
-        foreach ($this->Fields() as $field) {
+        foreach ($this->data()->Fields() as $field) {
             if (!$field->showInReports()) {
                 continue;
             }
diff --git a/code/Form/UserForm.php b/code/Form/UserForm.php
index b915a7e..a22ae41 100644
--- a/code/Form/UserForm.php
+++ b/code/Form/UserForm.php
@@ -122,7 +122,7 @@ class UserForm extends Form
         $fields = new UserFormsFieldList();
         $target = $fields;
 
-        foreach ($this->controller->Fields() as $field) {
+        foreach ($this->controller->data()->Fields() as $field) {
             $target = $target->processNext($field);
         }
         $fields->clearEmptySteps();
@@ -170,6 +170,7 @@ class UserForm extends Form
         // Generate required field validator
         $requiredNames = $this
             ->getController()
+            ->data()
             ->Fields()
             ->filter('Required', true)
             ->column('Name');