tonyair/silverstripe-userforms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-userforms.git synced 2024-06-26 06:29:27 +02:00
Code Issues Projects Releases Wiki Activity

Avoid calling getter twice

Browse Source
This commit is contained in:
Alexandre Saelens 2019-01-17 12:47:09 +13:00
parent 2e60a79e40
commit 6acee54596
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
code/Control/UserDefinedFormController.php
View File

@ -326,7 +326,8 @@ JS
}
// check to see if they are a dynamic reply to. eg based on a email field a user selected
if ($recipient->SendEmailFromField() && $recipient->SendEmailFromField()->exists()) {
$emailFrom = $recipient->SendEmailFromField();
if ($emailFrom && $emailFrom->exists()) {
$submittedFormField = $submittedFields->find('Name', $recipient->SendEmailFromField()->Name);
if ($submittedFormField && is_string($submittedFormField->Value)) {
@ -342,7 +343,8 @@ JS
}
// check to see if they are a dynamic reciever eg based on a dropdown field a user selected
if ($recipient->SendEmailToField() && $recipient->SendEmailToField()->exists()) {
$emailTo = $recipient->SendEmailToField();
if ($emailTo && $emailTo->exists()) {
$submittedFormField = $submittedFields->find('Name', $recipient->SendEmailToField()->Name);
if ($submittedFormField && is_string($submittedFormField->Value)) {
@ -355,7 +357,8 @@ JS
}
// check to see if there is a dynamic subject
if ($recipient->SendEmailSubjectField() && $recipient->SendEmailSubjectField()->exists()) {
$emailSubject = $recipient->SendEmailSubjectField();
if ($emailSubject && $emailSubject->exists()) {
$submittedFormField = $submittedFields->find('Name', $recipient->SendEmailSubjectField()->Name);
if ($submittedFormField && trim($submittedFormField->Value)) {