tonyair/silverstripe-userforms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-userforms.git synced 2024-10-22 17:05:42 +02:00
Code Issues Projects Releases Wiki Activity

ENH Avoid use of 'new' keyword on injectable classes from this module.

Browse Source 
It's not uncommon to want to override or enhance some functionality in vendor code that doesn't have extension points, so we should avoid the `new` keyword when instantiating injectable classes from the module.
This commit is contained in:
GuySartorelli 2021-05-31 13:00:31 +12:00 committed by GitHub
parent 4d9e78a841
commit 3fbccea2ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/Form/UserForm.php
View File

@ -118,7 +118,7 @@ class UserForm extends Form
*/
public function getFormFields()
{
$fields = new UserFormsFieldList();
$fields = UserFormsFieldList::create();
$target = $fields;
foreach ($this->controller->data()->Fields() as $field) {
@ -174,7 +174,7 @@ class UserForm extends Form
->filter('Required', true)
->column('Name');
$requiredNames = array_merge($requiredNames, $this->getEmailRecipientRequiredFields());
$required = new UserFormsRequiredFields($requiredNames);
$required = UserFormsRequiredFields::create($requiredNames);
$this->extend('updateRequiredFields', $required);
$required->setForm($this);
return $required;