tonyair/silverstripe-userforms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-userforms.git synced 2024-10-22 17:05:42 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1247 from creative-commoners/pulls/6.1/remove-todo

Browse Source 
MNT Remove TODO comments
This commit is contained in:
Guy Sartorelli 2023-10-20 11:54:21 +13:00 committed by GitHub
commit 18aa93d74a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/Form/UserForm.php
View File

@ -135,8 +135,6 @@ class UserForm extends Form
* can manipulate these by using {@link updateFormActions()} on * can manipulate these by using {@link updateFormActions()} on
* a decorator. * a decorator.
* *
* @todo Make form actions editable via their own field editor.
*
* @return FieldList * @return FieldList
*/ */
public function getFormActions() public function getFormActions()

1
code/Model/EditableFormField/EditableCheckboxGroupField.php
View File

@ -61,7 +61,6 @@ class EditableCheckboxGroupField extends EditableMultipleOptionField
public function getSelectorField(EditableCustomRule $rule, $forOnLoad = false) public function getSelectorField(EditableCustomRule $rule, $forOnLoad = false)
{ {
// watch out for checkboxs as the inputs don't have values but are 'checked // watch out for checkboxs as the inputs don't have values but are 'checked
// @todo - Test this
if ($rule->FieldValue) { if ($rule->FieldValue) {
return "$(\"input[name='{$this->Name}[]'][value='{$rule->FieldValue}']\")"; return "$(\"input[name='{$this->Name}[]'][value='{$rule->FieldValue}']\")";
} else { } else {

1
code/Model/EditableFormField/EditableLiteralField.php
View File

@ -149,7 +149,6 @@ class EditableLiteralField extends EditableFormField
$field = CompositeField::create($content) $field = CompositeField::create($content)
->setName($this->Name) ->setName($this->Name)
// ->setID($this->Name) // @todo: https://github.com/silverstripe/silverstripe-framework/issues/7264
->setFieldHolderTemplate(__CLASS__ . '_holder'); ->setFieldHolderTemplate(__CLASS__ . '_holder');
$this->doUpdateFormField($field); $this->doUpdateFormField($field);

2
code/Model/Recipient/EmailRecipient.php
View File

@ -177,7 +177,7 @@ class EmailRecipient extends DataObject
} }
// Revert to checking for a form from the session // Revert to checking for a form from the session
// LeftAndMain::sessionNamespace is protected. @todo replace this with a non-deprecated equivalent. // LeftAndMain::sessionNamespace is protected.
$sessionNamespace = $this->config()->get('session_namespace') ?: CMSMain::class; $sessionNamespace = $this->config()->get('session_namespace') ?: CMSMain::class;
$formID = Controller::curr()->getRequest()->getSession()->get($sessionNamespace . '.currentPage'); $formID = Controller::curr()->getRequest()->getSession()->get($sessionNamespace . '.currentPage');

2
code/Task/RecoverUploadLocationsHelper.php
View File

@ -447,8 +447,6 @@ class RecoverUploadLocationsHelper
'"SubmittedFileFieldTable"."UploadedFileID" > ?' => $greaterThanID '"SubmittedFileFieldTable"."UploadedFileID" > ?' => $greaterThanID
])->execute(); ])->execute();
// TODO: Versioned::prepopulate_versionnumber_cache
foreach ($chunk as $item) { foreach ($chunk as $item) {
yield $item; yield $item;
$greaterThanID = $item['UploadedFileID']; $greaterThanID = $item['UploadedFileID'];

1
tests/php/Model/UserDefinedFormTest.php
View File

@ -49,7 +49,6 @@ class UserDefinedFormTest extends FunctionalTest
'UserDefinedForm::rollback() has not been implemented completely' 'UserDefinedForm::rollback() has not been implemented completely'
); );
// @todo
$this->logInWithPermission('ADMIN'); $this->logInWithPermission('ADMIN');
/** @var UserDefinedForm|Versioned $form */ /** @var UserDefinedForm|Versioned $form */
$form = $this->objFromFixture(UserDefinedForm::class, 'basic-form-page'); $form = $this->objFromFixture(UserDefinedForm::class, 'basic-form-page');