tonyair
/
silverstripe-translatable
mirror of https://github.com/silverstripe/silverstripe-translatable
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ENHANCEMENT: significant speed improvement for many locales 

Iterating over an array of locales and querying for each one causes tons
of unnecessary queries. This is especially evident when you get up to
hundreds of translations of a page. It makes the CMS admin UI insufferably
slow.  This is a little tweak to query for all of them at once instead of
individually.
This commit is contained in:
Jeremy Thomerson 2013-07-14 21:08:14 +00:00
parent 42f048f34a
commit 9771d97e1f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
code/model/Translatable.php
View File

@ -1010,12 +1010,11 @@ class Translatable extends DataExtension implements PermissionProvider {
));
if(!$tab->fieldByName('existingtrans')) {
$existingTransHTML = '<ul>';
foreach($alreadyTranslatedLocales as $langCode) {
$existingTranslation = $this->owner->getTranslation($langCode);
foreach($this->getTranslations() as $existingTranslation) {
if($existingTranslation && $existingTranslation->hasMethod('CMSEditLink')) {
$existingTransHTML .= sprintf('<li><a href="%s">%s</a></li>',
sprintf('%s/?locale=%s', $existingTranslation->CMSEditLink(), $langCode),
i18n::get_locale_name($langCode)
sprintf('%s/?locale=%s', $existingTranslation->CMSEditLink(), $existingTranslation->Locale),
i18n::get_locale_name($existingTranslation->Locale)
);
}
}