tonyair/silverstripe-translatable
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-translatable synced 2024-10-22 11:05:59 +02:00
Code Issues Projects Releases Wiki Activity

BUG: double ajax request for page editing in default locale

Browse Source 
When editing a page in the default locale, a double ajax request was done for the editing page.
This was caused by no locale-parameter being set in this case, which caused the default locale
parameter to be added and a new ajax request was made due to this. The extra ajax request caused
the loading-animation to appear after the edit page was loaded, which looks weird.
Fixed by doing a redirect immediately the CMSPagesController is loaded and no locale is set, so
that the default locale parameter gets set at this stage.
This commit is contained in:
Niklas Forsdahl 2012-09-03 10:26:55 +03:00
parent c3c9f1f83f
commit 1c40751d51
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
code/controller/TranslatableCMSMainExtension.php
View File

@ -29,6 +29,11 @@ class TranslatableCMSMainExtension extends Extension {
if($record && $record->Locale) $this->owner->Locale = $record->Locale; if($record && $record->Locale) $this->owner->Locale = $record->Locale;
} else { } else {
$this->owner->Locale = Translatable::default_locale(); $this->owner->Locale = Translatable::default_locale();
if ($this->owner->class == 'CMSPagesController') {
// the CMSPagesController always needs to have the locale set, otherwise page editing will cause an extra
// ajax request which looks weird due to multiple "loading"-flashes
return $this->owner->redirect($this->owner->Link());
}
} }
Translatable::set_current_locale($this->owner->Locale); Translatable::set_current_locale($this->owner->Locale);