tonyair/silverstripe-textextraction
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-textextraction synced 2024-10-22 11:06:00 +02:00
Code Issues Projects Releases Wiki Activity

Move test data to versionProvider()

Browse Source
This commit is contained in:
Steve Boyd 2018-07-11 16:38:12 +12:00 committed by GitHub
parent b29e189cb5
commit 856e5fdf0b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/TikaTextExtractorTest.php
View File

@ -48,17 +48,22 @@ class TikaTextExtractorTest extends SapphireTest
$method = $reflection->getMethod('normaliseVersion'); $method = $reflection->getMethod('normaliseVersion');
$method->setAccessible(true); $method->setAccessible(true);
$arr = [ foreach ($this->versionProvider() as $data) {
'1.7.1' => '1.7.1', list($input, $expected) = $data;
'1.7' => '1.7.0',
'1' => '1.0.0',
null => '0.0.0',
'v1.5' => 'v1.5.0',
'carrot' => 'carrot.0.0'
];
foreach ($arr as $input => $expected) {
$actual = $method->invoke($extractor, $input); $actual = $method->invoke($extractor, $input);
$this->assertEquals($expected, $actual); $this->assertEquals($expected, $actual);
} }
} }
protected function versionProvider()
{
return [
['1.7.1', '1.7.1'],
['1.7', '1.7.0'],
['1', '1.0.0'],
[null, '0.0.0'],
['v1.5', 'v1.5.0'],
['carrot', 'carrot.0.0']
];
}
} }