tonyair/silverstripe-textextraction
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-textextraction synced 2024-10-22 09:06:00 +00:00
Code Issues Projects Releases Wiki Activity

Update isAvailable check to work for identical versions

Browse Source 
Tika server reports it's version as "Apache Tika 1.7". Unfortunately, `version_compare` in PHP says that version "1.7" is less than version "1.7.0", meaning that Tika server was incorrectly being ruled out unless you used Tika server version 1.8 (where "1.8" > "1.7.0").

Changing the comparison string to just "1.7" means they match exactly, and therefore `version_compare` will return `0` rather than `-1`.
This commit is contained in:
Ishan Jayamanne 2019-02-13 17:12:58 +13:00 committed by Robbie Averill
parent 07c000dc0d
commit 21ed6e0f86
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Extractor/TikaServerTextExtractor.php
View File

@ -86,7 +86,7 @@ class TikaServerTextExtractor extends FileTextExtractor
{ {
return $this->getServerEndpoint() return $this->getServerEndpoint()
&& $this->getClient()->isAvailable() && $this->getClient()->isAvailable()
&& version_compare($this->getVersion(), '1.7.0') >= 0; && version_compare($this->getVersion(), '1.7') >= 0;
} }
/** /**