From dc932bd72ddfd2abf0f5733f03c8d26e5ede9a8e Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Thu, 24 Nov 2022 17:39:57 +1300 Subject: [PATCH] API Stop using deprecated API --- src/StringTagField.php | 6 +++++- tests/StringTagFieldTest.php | 11 +++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/StringTagField.php b/src/StringTagField.php index 090f006..fe55c28 100644 --- a/src/StringTagField.php +++ b/src/StringTagField.php @@ -6,6 +6,7 @@ use Iterator; use SilverStripe\Control\Controller; use SilverStripe\Control\HTTPRequest; use SilverStripe\Control\HTTPResponse; +use SilverStripe\Dev\Deprecation; use SilverStripe\Forms\DropdownField; use SilverStripe\Forms\Validator; use SilverStripe\ORM\ArrayList; @@ -281,7 +282,10 @@ class StringTagField extends DropdownField $record->$name = $this->dataValue(); - if (self::config()->get('immediate_write_enabled')) { + $immediate_write_enabled = Deprecation::withNoReplacement(function () { + return self::config()->get('immediate_write_enabled'); + }); + if ($immediate_write_enabled) { $record->write(); } } diff --git a/tests/StringTagFieldTest.php b/tests/StringTagFieldTest.php index 024fd71..ea35c04 100755 --- a/tests/StringTagFieldTest.php +++ b/tests/StringTagFieldTest.php @@ -8,6 +8,7 @@ use SilverStripe\Forms\FieldList; use SilverStripe\Forms\Form; use SilverStripe\TagField\StringTagField; use SilverStripe\TagField\Tests\Stub\StringTagFieldTestBlogPost; +use SilverStripe\Dev\Deprecation; class StringTagFieldTest extends SapphireTest { @@ -63,10 +64,13 @@ class StringTagFieldTest extends SapphireTest public function testImmediateWriteEnabled() { + if (Deprecation::isEnabled()) { + $this->markTestSkipped('Test calls deprecated code'); + } $record = $this->getNewStringTagFieldTestBlogPost('BlogPost1'); $record->write(); - StringTagField::config()->update('immediate_write_enabled', true); + StringTagField::config()->set('immediate_write_enabled', true); $field = new StringTagField('Tags'); $field->setValue(['Tag1', 'Tag2']); @@ -77,10 +81,13 @@ class StringTagFieldTest extends SapphireTest public function testImmediateWriteDisabled() { + if (Deprecation::isEnabled()) { + $this->markTestSkipped('Test calls deprecated code'); + } $record = $this->getNewStringTagFieldTestBlogPost('BlogPost1'); $record->write(); - StringTagField::config()->update('immediate_write_enabled', false); + StringTagField::config()->set('immediate_write_enabled', false); $field = new StringTagField('Tags'); $field->setValue(['Tag1', 'Tag2']);